From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id ACA3538582AB for ; Thu, 11 May 2023 08:59:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACA3538582AB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4f00d41df22so45810595e87.1 for ; Thu, 11 May 2023 01:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683795579; x=1686387579; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3BZzGaXMbXCeAXIvV/NNbRLGnxlKt/bBoKe4qzlyzQQ=; b=MMFTn2BaZI7dXXtpFazuLlTEPJEs1VPXFfBsPwRebLZsf9aYAfHvGkr14qp266GT51 BkvMkaYolX4QNyY2f0LX5Fs96sC6UtTnsO3+CcYqoSY5V7s8oLClG/3YrN0+TB3BZ52G Ka32nLBvVDN65OrqZnAm2BQ+r/AQCqVHGyHGF1xHHp9MDW0jXrKVLU28BWxrTnCzZsng dVKh7l/8LbIV4qOMxjoNxTp1Fqf2PnwrMiGKQOcajQVLlcr9pvjY+m0r6G4XfxBXZeM7 GiupUBeU/Ci+CQ43VoT8ONb0Ay8azLyLfIe6DQAVDvWwP1ePw5EwB2LJhw238R7Lnnk/ +Sdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683795579; x=1686387579; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3BZzGaXMbXCeAXIvV/NNbRLGnxlKt/bBoKe4qzlyzQQ=; b=X6qZJiR2iqGhaAWokYq70A2XKKo0L9yFiR9ZiGnQRUadfkA+WcsyuLRBuiq1JZ9ljv DKG4s77Oz+ORWwh6Y+X1AVX3raCIHdxRU8Bfovf0pbckmGY1Df8nbBy2IH8VIvQM/NWc YxCJDayynScwoykeFgPXLidvjyan/ALQSZ2GKdNfq7dTb6/e+WpWZYWVrFRtk7Uz88b5 GjD7bdfrB5qMgp3U6ew4rH4jxTPgLberZQANNGOsqK1+e47yy7hSWqcs/pfqlndpnxUa fajqr8vrt2e3BBfHtwl5HCxInM0zQEE9PzTUf4ZOmOUBdW1vci++N2oUY5RceBWK70lJ 4Tqw== X-Gm-Message-State: AC+VfDzJpDY0LRWJ+Z2A3YOaqe6ZKaqiTuHbpC3iFYNBn837dHSlBuzM GkV1cnNReXFpJI8Zi4DzEco0Ds9qvAWhoLYUktNhjuGq7GE= X-Google-Smtp-Source: ACHHUZ7Skv7F8qh/49z0WKgdptQS+9lOTs8hiv+tVDlR0NlI7mPcpCiLVfhedI0dvlsk9tMYdFjYkor3oD5dbB0I0Ho= X-Received: by 2002:ac2:5089:0:b0:4ef:d567:4854 with SMTP id f9-20020ac25089000000b004efd5674854mr2680040lfm.11.1683795578930; Thu, 11 May 2023 01:59:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Thu, 11 May 2023 10:57:44 +0200 Message-ID: Subject: Re: [EXTERNAL] Re: [PATCH] Fixes and workarounds for warnings during autoprofiledbootstrap build To: Eugene Rozenfeld Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 11, 2023 at 4:23=E2=80=AFAM Eugene Rozenfeld wrote: > > I'm ok with disabling warnings as errors for autoprofiledbootstrap. What'= s the proper way to do that? Searching for "--disable-werror" I see matches= in lib configure files but not in gcc files. We have --with-build-config selecting things like bootstrap-O3 and configure then disables werror by default if the build config is anything other than the default or bootstrap-debug. Of course profiledbootstrap and autoprofiledbootstrap are not build configs= but make targets - that makes it more difficult (or impossible) to use the --disable-werror machinery here. There is STAGE_CONFIGURE_FLAGS=3D@stage2_werror_flag@ so it might be possible to filter out --enable-werror-always from STAGEautofeedback_CONFIGURE_FLAGS? Richard. > Thanks, > > Eugene > > -----Original Message----- > From: Richard Biener > Sent: Tuesday, May 9, 2023 11:40 PM > To: Eugene Rozenfeld > Cc: gcc-patches@gcc.gnu.org > Subject: [EXTERNAL] Re: [PATCH] Fixes and workarounds for warnings during= autoprofiledbootstrap build > > On Wed, May 10, 2023 at 3:38=E2=80=AFAM Eugene Rozenfeld via Gcc-patches = wrote: > > > > autoprofiledbootstrap build produces new warnings since inlining > > decisions are different from other builds. This patch contains fixes > > and workarounds for those warnings. > > > > Tested on x86_64-pc-linux-gnu. > > Rather than this would it make sense to add --disable-werror to autoprofi= ledbootstrap configs like we do for others? I also wonder how "stable" the= afdo bootstrap inlining decisions are, so applying these workarounds may n= ot be sustainable? > > > gcc/ChangeLog: > > > > * config/i386/i386-expand.cc (expand_vec_perm_interleave2): Wor= k around > > -Wstringop-overflow false positive during autoprofiledbootstrap > > * ipa-devirt.cc (debug_tree_odr_name): Fix for -Wformat-overflo= w > > warning during autoprofiledbootstrap > > * lra-eliminations.cc (setup_can_eliminate): Work around > > -Wmaybe-uninitialized false positive during autoprofiledbootstr= ap > > * opts-common.cc (candidates_list_and_hint): Work around > > -Wstringop-overflow false positive during autoprofiledbootstrap > > * tree-ssa-ccp.cc (bit_value_unop): Work around -Wmaybe-uniniti= alized > > false positive during autoprofiledbootstrap > > * wide-int.h (wi::copy): Work around -Wmaybe-uninitialized fals= e > > positive during autoprofiledbootstrap > > --- > > gcc/config/i386/i386-expand.cc | 11 +++++++++++ > > gcc/ipa-devirt.cc | 3 ++- > > gcc/lra-eliminations.cc | 11 +++++++++++ > > gcc/opts-common.cc | 1 + > > gcc/tree-ssa-ccp.cc | 11 +++++++++++ > > gcc/wide-int.h | 11 +++++++++++ > > 6 files changed, 47 insertions(+), 1 deletion(-) > > > > diff --git a/gcc/config/i386/i386-expand.cc > > b/gcc/config/i386/i386-expand.cc index 634fe61ba79..be9f912775b 100644 > > --- a/gcc/config/i386/i386-expand.cc > > +++ b/gcc/config/i386/i386-expand.cc > > @@ -20419,6 +20419,13 @@ expand_vec_perm_pblendv (struct > > expand_vec_perm_d *d) > > > > static bool expand_vec_perm_interleave3 (struct expand_vec_perm_d > > *d); > > > > +/* Work around -Wstringop-overflow false positive during > > +autoprofiledbootstrap. */ > > + > > +# if GCC_VERSION >=3D 7001 > > +#pragma GCC diagnostic push > > +#pragma GCC diagnostic ignored "-Wstringop-overflow" > > +#endif > > + > > /* A subroutine of ix86_expand_vec_perm_const_1. Try to simplify > > a two vector permutation into a single vector permutation by using > > an interleave operation to merge the vectors. */ @@ -20737,6 > > +20744,10 @@ expand_vec_perm_interleave2 (struct expand_vec_perm_d *d) > > return true; > > } > > > > +# if GCC_VERSION >=3D 7001 > > +#pragma GCC diagnostic pop > > +#endif > > + > > /* A subroutine of ix86_expand_vec_perm_const_1. Try to simplify > > a single vector cross-lane permutation into vpermq followed > > by any of the single insn permutations. */ diff --git > > a/gcc/ipa-devirt.cc b/gcc/ipa-devirt.cc index 819860258d1..36ea266e834 > > 100644 > > --- a/gcc/ipa-devirt.cc > > +++ b/gcc/ipa-devirt.cc > > @@ -4033,7 +4033,8 @@ debug_tree_odr_name (tree type, bool demangle) > > odr =3D cplus_demangle (odr, opts); > > } > > > > - fprintf (stderr, "%s\n", odr); > > + if (odr !=3D NULL) > > + fprintf (stderr, "%s\n", odr); > > } > > > > /* Register ODR enum so we later stream record about its values. */ > > diff --git a/gcc/lra-eliminations.cc b/gcc/lra-eliminations.cc index > > 42206366669..05e2a7e0d68 100644 > > --- a/gcc/lra-eliminations.cc > > +++ b/gcc/lra-eliminations.cc > > @@ -138,6 +138,13 @@ lra_debug_elim_table (void) > > print_elim_table (stderr); > > } > > > > +/* Work around -Wmaybe-uninitialized false positive during > > +autoprofiledbootstrap. */ > > + > > +# if GCC_VERSION >=3D 4007 > > +#pragma GCC diagnostic push > > +#pragma GCC diagnostic ignored "-Wmaybe-uninitialized" > > +#endif > > + > > /* Setup possibility of elimination in elimination table element EP to > > VALUE. Setup FRAME_POINTER_NEEDED if elimination from frame > > pointer to stack pointer is not possible anymore. */ @@ -152,6 > > +159,10 @@ setup_can_eliminate (class lra_elim_table *ep, bool value) > > REGNO_POINTER_ALIGN (HARD_FRAME_POINTER_REGNUM) =3D 0; } > > > > +# if GCC_VERSION >=3D 4007 > > +#pragma GCC diagnostic pop > > +#endif > > + > > /* Map: eliminable "from" register -> its current elimination, > > or NULL if none. The elimination table may contain more than > > one elimination for the same hard register, but this map specifies > > diff --git a/gcc/opts-common.cc b/gcc/opts-common.cc index > > 23ddcaa3b55..0bb8e34e2b0 100644 > > --- a/gcc/opts-common.cc > > +++ b/gcc/opts-common.cc > > @@ -1388,6 +1388,7 @@ candidates_list_and_hint (const char *arg, char *= &str, > > p[len] =3D ' '; > > p +=3D len + 1; > > } > > + gcc_assert(p > str); > > p[-1] =3D '\0'; > > return find_closest_string (arg, &candidates); } diff --git > > a/gcc/tree-ssa-ccp.cc b/gcc/tree-ssa-ccp.cc index > > 03a984f2adf..a54e5a90464 100644 > > --- a/gcc/tree-ssa-ccp.cc > > +++ b/gcc/tree-ssa-ccp.cc > > @@ -1976,6 +1976,13 @@ bit_value_binop (enum tree_code code, signop sgn= , int width, > > } > > } > > > > +/* Work around -Wmaybe-uninitialized false positive during > > +autoprofiledbootstrap. */ > > + > > +# if GCC_VERSION >=3D 4007 > > +#pragma GCC diagnostic push > > +#pragma GCC diagnostic ignored "-Wmaybe-uninitialized" > > +#endif > > + > > /* Return the propagation value when applying the operation CODE to > > the value RHS yielding type TYPE. */ > > > > @@ -2011,6 +2018,10 @@ bit_value_unop (enum tree_code code, tree type, = tree rhs) > > return val; > > } > > > > +# if GCC_VERSION >=3D 4007 > > +#pragma GCC diagnostic pop > > +#endif > > + > > /* Return the propagation value when applying the operation CODE to > > the values RHS1 and RHS2 yielding type TYPE. */ > > > > diff --git a/gcc/wide-int.h b/gcc/wide-int.h index > > 6be343c0eb5..9c50dd869b6 100644 > > --- a/gcc/wide-int.h > > +++ b/gcc/wide-int.h > > @@ -1806,6 +1806,13 @@ wi::get_binary_precision (const T1 &x, const T2 = &y) > > get_binary_result (x, y)); } > > > > +/* Work around -Wmaybe-uninitialized false positive during > > +autoprofiledbootstrap. */ > > + > > +# if GCC_VERSION >=3D 4007 > > +#pragma GCC diagnostic push > > +#pragma GCC diagnostic ignored "-Wmaybe-uninitialized" > > +#endif > > + > > /* Copy the contents of Y to X, but keeping X's current precision. > > */ template inline void @@ -1821,6 > > +1828,10 @@ wi::copy (T1 &x, const T2 &y) > > x.set_len (len, y.is_sign_extended); } > > > > +# if GCC_VERSION >=3D 4007 > > +#pragma GCC diagnostic pop > > +#endif > > + > > /* Return true if X fits in a HOST_WIDE_INT with no loss of > > precision. */ template inline bool > > -- > > 2.25.1 > >