From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31458 invoked by alias); 24 Oct 2011 10:36:05 -0000 Received: (qmail 31295 invoked by uid 22791); 24 Oct 2011 10:36:04 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vw0-f47.google.com (HELO mail-vw0-f47.google.com) (209.85.212.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Oct 2011 10:35:50 +0000 Received: by vwe42 with SMTP id 42so4866254vwe.20 for ; Mon, 24 Oct 2011 03:35:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.30.69 with SMTP id q5mr21765152vdh.110.1319452549585; Mon, 24 Oct 2011 03:35:49 -0700 (PDT) Received: by 10.52.169.1 with HTTP; Mon, 24 Oct 2011 03:35:49 -0700 (PDT) In-Reply-To: References: <20111020221932.GA13355@kam.mff.cuni.cz> <201110210229.p9L2TKmx010677@ignucius.se.axis.com> <20111021093112.GD2976@kam.mff.cuni.cz> <63B3C6F6-2C30-4A7C-A324-8805D8AA8667@sandoe-acoustics.co.uk> Date: Mon, 24 Oct 2011 12:08:00 -0000 Message-ID: Subject: Re: [RFA:] fix breakage with "Update testsuite to run with slim LTO" From: Richard Guenther To: Rainer Orth Cc: Iain Sandoe , Jan Hubicka , Hans-Peter Nilsson , GCC Patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg02162.txt.bz2 On Fri, Oct 21, 2011 at 1:56 PM, Rainer Orth wrote: > Iain Sandoe writes: > >> It looks like the gnat testsuite is also broken - but HP's fix doesn't >> recover that. >> .. will try and take a look - but short on time today, > > I think I see what's going on: in gnat.log, I find > > Running /vol/gcc/src/hg/trunk/local/gcc/testsuite/gnat.dg/dg.exp ... > ERROR: tcl error sourcing library file /vol/gcc/src/hg/trunk/local/gcc/te= stsuite/lib/gcc-dg.exp. > can't read "GCC_UNDER_TEST": no such variable > can't read "GCC_UNDER_TEST": no such variable > =A0 =A0while executing > "lappend options "compiler=3D$GCC_UNDER_TEST"" > =A0 =A0(procedure "gcc_target_compile" line 37) > =A0 =A0invoked from within > "gcc_target_compile $source $dest $type $options" > =A0 =A0invoked from within > "if [ string match "*.c" $source ] then { > =A0 =A0 =A0 =A0return [gcc_target_compile $source $dest $type $options] > =A0 =A0}" > =A0 =A0(procedure "gnat_target_compile" line 12) > =A0 =A0invoked from within > "${tool}_target_compile $src $output $compile_type "$options"" > =A0 =A0(procedure "check_compile" line 39) > =A0 =A0invoked from within > "check_compile linker_plugin executable { > =A0 =A0 int main() { return 0; } > =A0} {-flto -fuse-linker-plugin}" > =A0 =A0("eval" body line 1) > =A0 =A0invoked from within > "eval check_compile $args" > =A0 =A0(procedure "check_no_compiler_messages_nocache" line 2) > =A0 =A0invoked from within > "check_no_compiler_messages_nocache linker_plugin executable { > =A0 =A0 int main() { return 0; } > =A0} "-flto -fuse-linker-plugin"" > =A0 =A0(procedure "check_linker_plugin_available" line 2) > =A0 =A0invoked from within > "check_linker_plugin_available" > =A0 =A0invoked from within > "if [check_effective_target_lto] { > =A0 =A0# When having plugin test both slim and fat LTO and plugin/nonplug= in > =A0 =A0# path. > =A0 =A0if [check_linker_plugin_ava..." > =A0 =A0(file "/vol/gcc/src/hg/trunk/local/gcc/testsuite/lib/gcc-dg.exp" l= ine 71) > =A0 =A0invoked from within > "source /vol/gcc/src/hg/trunk/local/gcc/testsuite/lib/gcc-dg.exp" > =A0 =A0("uplevel" body line 1) > =A0 =A0invoked from within > "uplevel #0 source /vol/gcc/src/hg/trunk/local/gcc/testsuite/lib/gcc-dg.e= xp" > > If running the gnat.dg testsuite, lib/gcc-dg.exp is now calling > check_linker_plugin_available early, which ultimately calls > ${tool}_target_compile. =A0For all languages but Ada, > ${tool}_target_compile can compile .c files just fine, but > gnat_target_compile (which uses gnatmake) cannot, so it falls back to > directly calling gcc_target_compile in that case. =A0gcc_target_compile > relies on GCC_UNDER_TEST being set, which in this case hasn't yet > happened, thus the error. > > My solution (a hack, actually) is to move the initialization of > GCC_UNDER_TEST in gcc-dg.exp before the calls to > check_linker_plugin_available. =A0x86_64-unknown-linux-gnu testing in > progress, will commit once that's finished. > > Btw., the ChangeLog entry for Jan's patch was riddled with typos and > wrong pathnames. =A0I've corrected that with a separate checkin. Still doesn't work for me: rguenther@murzim:/abuild/rguenther/trunk-g/gcc> make check-gfortran RUNTESTFLAGS=3D"dg.exp=3Dlogical_dot_product.f90" ... Running /space/rguenther/src/svn/trunk/gcc/testsuite/gfortran.dg/dg.exp ... ERROR: (DejaGnu) proc "gcc_target_compile linker_plugin14146.o linker_plugin14146 executable { additional_flags=3D-flto additional_flags=3D-flto-partition=3Dnone additional_flags=3D-save-temps }" does not exist. The error code is NONE The info on the error is: close: spawn id exp6 not open while executing "close -i exp6" invoked from within "catch "close -i $spawn_id"" This is highly annoying for me ... (reverting Rainers patch doesn't help). Richard.