From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 400B93858C60 for ; Thu, 2 Feb 2023 13:31:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 400B93858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22a.google.com with SMTP id h17so1882796ljq.4 for ; Thu, 02 Feb 2023 05:31:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XHnZZq2nPbikA/WrDSRbx86nudVzZemZIfj0wJKpujY=; b=Iiow4kvqMuRmy0N1W819uyKDpxTMPVQbgVDFgk0jCKkzf78n6EINN4pJv/4Dxj27sV mUZkixuEehF0LjpUKM6idXTIinQpIONukw0+yxypzKN30Es8ffnSadq22i9wQc8osOAL QjeZRp6C1Fhr+HvmgVCkDW0fcVNE+UhxvmRuRgiqp0GVDhwhh7k++RiEQcUOHo1NaeA9 znsi660INNHKrWvwNh7mW8L7ta5CHQm4VkJs01JDB2Nalyqc1Qt1OaPnQ/x0CLXVNWhK 5UkHEYiIZ/Q0TuaYbOqrZzHRi1APnk/+CG9Tm9N7e2V3RZIBW8UzBZBNJcLik1dv1tft c1bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XHnZZq2nPbikA/WrDSRbx86nudVzZemZIfj0wJKpujY=; b=InKLhqpf4p+WvNG8r1u1VJHHmSNxR1L3jixRBQZKuV4TJFAKUVJmg2MnMEHsvSf5gC T6HKgBlki9yEpuiDe3JVs6GebxlhlvXQHnh8yuv3FU9LGJXMeb47HGFxPcJkf7/WyXLU C3gpWzjNsP1jnrh+IHCICmmmU+3YdadDJAjpBLSU1RQ6qECP+VBeIp9+A7VCVTKBRcLh 9iAHWGG/BZrPXEwM1Yemp0F822aSouhyhzuVIMrG+Ra2bsNy6K+9DUDIkQGRurAZHHr4 jpoIuPM9Lz5TsyIvDuGvKR5/pzxczReyqLS+YklkxkBXbWKTZKzyCn8lYwoW8RkvE3U/ 0cZQ== X-Gm-Message-State: AO0yUKVeH25RqXetzC4GsOPpymbj79A82/OOHJLN4FnMuDIN7riAr+zi tMli98vmN1aQCM6znk1yMwzmFs2FJYIE5QjNgaubvSq9 X-Google-Smtp-Source: AK7set+Ngnm/tzEt/MUB0KZ7BCUQoXTAVBaZoNwlH4eVkqbx1l75jKYopOLdKH5U9Et9Dg8NQs9yoRQ4pOMdQZ6KxU8= X-Received: by 2002:a2e:9b95:0:b0:290:5179:a344 with SMTP id z21-20020a2e9b95000000b002905179a344mr972797lji.47.1675344700617; Thu, 02 Feb 2023 05:31:40 -0800 (PST) MIME-Version: 1.0 References: <20230129113451.24516-1-iain@sandoe.co.uk> <069B07DC-BC64-416D-9846-08A5C624E773@sandoe.co.uk> In-Reply-To: <069B07DC-BC64-416D-9846-08A5C624E773@sandoe.co.uk> From: Richard Biener Date: Thu, 2 Feb 2023 14:31:28 +0100 Message-ID: Subject: Re: [PATCH] driver, toplevel: Avoid emitting the version information twice. To: Iain Sandoe Cc: GCC Patches , Joseph Myers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 2, 2023 at 12:41 PM Iain Sandoe wrote: > > > > > On 30 Jan 2023, at 07:48, Richard Biener w= rote: > > > > On Sun, Jan 29, 2023 at 12:35 PM Iain Sandoe via Gcc-patches > > wrote: > >> > >> Technically, this is seems to be a regression somewhere between 4.2 an= d > >> 4.6 but, it seems, not enough for anyone to care too much. Tested on > >> various Darwin versions and x86_64, powerpc64 linux, > >> OK for trunk {now,stage1}? > > > > This will elide the earlier printing, right? > > Yes. > > > eliding the 2nd would be prefered so the info comes first? > > Indeed; that is better .. > > how about this update then? > OK for trunk now/stage1? OK now. Richard. > =E2=80=94 8< --- > > For a regular compile job, with -v we emit the GCC version information > twice - once from main() and once from process_options(). > > We do not need to output the second header. > > Signed-off-by: Iain Sandoe > > gcc/ChangeLog: > > * toplev.cc (toplev::main): Only print the version information he= ader > from toplevel main(). > --- > gcc/toplev.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/toplev.cc b/gcc/toplev.cc > index 42937f0ba00..4c15d4f542e 100644 > --- a/gcc/toplev.cc > +++ b/gcc/toplev.cc > @@ -1358,7 +1358,7 @@ process_options (bool no_backend) > option flags in use. */ > if (version_flag) > { > - print_version (stderr, "", true); > + /* We already printed the version header in main (). */ > if (!quiet_flag) > { > fputs ("options passed: ", stderr); > -- > 2.37.1 (Apple Git-137.1) > >