From: Richard Biener <richard.guenther@gmail.com>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"hernandez, aldy" <aldyh@redhat.com>
Subject: Re: [COMMITTED] Do not assume LHS of call is an ssa-name.
Date: Mon, 17 Jun 2024 08:23:08 +0200 [thread overview]
Message-ID: <CAFiYyc2Do=VPtV_Y-k0wMUJiCVfZcPK5b3=knEWoCjs+XzpBWQ@mail.gmail.com> (raw)
In-Reply-To: <6e111567-6aab-4123-9c2d-114a5cea0515@redhat.com>
On Fri, Jun 14, 2024 at 9:20 PM Andrew MacLeod <amacleod@redhat.com> wrote:
>
> gimple_range_fold makes an assumption that if there is a LHS on a call
> that it is an ssa_name. Especially later in compilation that may not be
> true.
It's always true if the LHS is of register type (is_gimple_reg_type) and
never true when the LHS is of aggregate type. So either range_of_call
should have not been invoked here or it should indeed be defensive
as in your patch.
> This patch merely avoids calling routines that assume an ssa-name is
> being passed in.
>
> Bootstraps on x86_64-pc-linux-gnu with no regressions. Pushed.
>
> Andrew
>
prev parent reply other threads:[~2024-06-17 6:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 19:20 Andrew MacLeod
2024-06-17 6:23 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc2Do=VPtV_Y-k0wMUJiCVfZcPK5b3=knEWoCjs+XzpBWQ@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).