From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81098 invoked by alias); 4 Oct 2016 08:18:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 81073 invoked by uid 89); 4 Oct 2016 08:18:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=HX-Envelope-From:sk:richard X-HELO: mail-wm0-f48.google.com Received: from mail-wm0-f48.google.com (HELO mail-wm0-f48.google.com) (74.125.82.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Oct 2016 08:18:05 +0000 Received: by mail-wm0-f48.google.com with SMTP id f193so22751160wmg.0 for ; Tue, 04 Oct 2016 01:18:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=O4O9AcSk7ODjEWTDXnIpxjP44db+Hy/KZ6okp0N4f0Q=; b=HWI1SYsa4x0V49UGvM8GTbhxnwReHJjSb5uh+yriunGgPjkT2VZAEkMVEs5pQ638HK GEGN8vV49J0XjfsKhB87cA9rC4DDJcTEdsP5dGHGYJFBWPFI9UrrJLlujzrk58ha/kDU G5oJfbgHsixtZ4kCEw4cui+qNgZx/kZ9TxRQNLIeBvDzZy6Z3pu7kJolekS1OC9AJE4l wpSnZPMNNVKRlgHOuuXLOwAwalu1w0bu5WqIbJDaCpfSnzFm2RPg3l717eol5ystTXjZ zP+4q3FbqaQ5iG2r+y9pBSE0OYwVjXuilIouksTp0kZkFEW7yhkMbzgNlEG8LVHR7cIl h2lw== X-Gm-Message-State: AA6/9RntiDXV7jJlvY0S1zu+r3k1nvxq12i5uuzxggLq4iGleJpN6GIhscp+7800JE3ExTa8jrsRhPZHhjQVZQ== X-Received: by 10.28.128.86 with SMTP id b83mr14278620wmd.40.1475569083222; Tue, 04 Oct 2016 01:18:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.155.210 with HTTP; Tue, 4 Oct 2016 01:18:02 -0700 (PDT) In-Reply-To: <57EE9992.3050106@foss.arm.com> References: <57EBE7A6.3040103@foss.arm.com> <57EE9992.3050106@foss.arm.com> From: Richard Biener Date: Tue, 04 Oct 2016 08:18:00 -0000 Message-ID: Subject: Re: [PATCH][v4] GIMPLE store merging pass To: Kyrill Tkachov Cc: Richard Biener , GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00125.txt.bz2 On Fri, Sep 30, 2016 at 6:57 PM, Kyrill Tkachov wrote: > Hi Richard, > > On 29/09/16 11:45, Richard Biener wrote: >> >> >> + gimple_seq seq = NULL; >> + unsigned int num_stmts = 0; >> + tree offset_type = get_type_for_merged_store (group); >> + tree last_vdef, new_vuse; >> + last_vdef = gimple_vdef (group->last_stmt); >> + new_vuse = gimple_vuse (group->last_stmt); >> + location_t loc = get_merged_store_location (group); >> If you end up splitting the store then please use a location appropriate >> for the split part. Likewise for the alias type. >> > > How would I get the appropriate alias type? > Is there some way to construct it from the alias type of the base > object offset by some number of bytes? You already have a function for this - it just looks at the whole group instead of a subgroup. As said, if you'd first split groups then then do the emission this part would resolve itself. Richard. > > Thanks, > Kyrill