From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21757 invoked by alias); 22 Sep 2014 10:52:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21747 invoked by uid 89); 22 Sep 2014 10:52:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f48.google.com Received: from mail-wg0-f48.google.com (HELO mail-wg0-f48.google.com) (74.125.82.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 22 Sep 2014 10:52:06 +0000 Received: by mail-wg0-f48.google.com with SMTP id z12so2481645wgg.7 for ; Mon, 22 Sep 2014 03:52:03 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.195.11.132 with SMTP id ei4mr1359726wjd.133.1411383123865; Mon, 22 Sep 2014 03:52:03 -0700 (PDT) Received: by 10.194.20.69 with HTTP; Mon, 22 Sep 2014 03:52:03 -0700 (PDT) In-Reply-To: <541AD198.4060504@arm.com> References: <541AC4D2.9040901@arm.com> <541AD198.4060504@arm.com> Date: Mon, 22 Sep 2014 10:52:00 -0000 Message-ID: Subject: Re: [PATCH 11/14] Remove VEC_LSHIFT_EXPR and vec_shl_optab From: Richard Biener To: Alan Lawrence Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg01795.txt.bz2 On Thu, Sep 18, 2014 at 2:35 PM, Alan Lawrence wrote: > The VEC_LSHIFT_EXPR tree code, and the corresponding vec_shl_optab, seem to > have been added for completeness, providing a counterpart to VEC_RSHIFT_EXPR > and vec_shr_optab. However, whereas VEC_RSHIFT_EXPRs are generated (only) by > the vectorizer, VEC_LSHIFT_EXPR expressions are not generated at all, so > there seems little point in maintaining it. > > Bootstrapped on x86_64-unknown-linux-gnu. > aarch64.exp+vect.exp on aarch64-none-elf and aarch64_be-none-elf. Ah, there it is ;) Ok. Thanks, Richard. > gcc/ChangeLog: > > * expr.c (expand_expr_real_2): Remove code handling VEC_LSHIFT_EXPR. > * fold-const.c (const_binop): Likewise. > * cfgexpand.c (expand_debug_expr): Likewise. > * tree-inline.c (estimate_operator_cost, dump_generic_node, > op_code_prio, op_symbol_code): Likewise. > * tree-vect-generic.c (expand_vector_operations_1): Likewise. > * optabs.c (optab_for_tree_code): Likewise. > (expand_vec_shift_expr): Likewise, update comment. > * tree.def: Delete VEC_LSHIFT_EXPR, remove comment. > * optabs.h (expand_vec_shift_expr): Remove comment re. > VEC_LSHIFT_EXPR. > * optabs.def: Remove vec_shl_optab. > * doc/md.texi: Remove references to vec_shr_m.