From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28245 invoked by alias); 5 Nov 2011 08:35:07 -0000 Received: (qmail 28042 invoked by uid 22791); 5 Nov 2011 08:35:06 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gx0-f175.google.com (HELO mail-gx0-f175.google.com) (209.85.161.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Nov 2011 08:34:53 +0000 Received: by ggnp1 with SMTP id p1so625280ggn.20 for ; Sat, 05 Nov 2011 01:34:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.74.37 with SMTP id q5mr1736599obv.32.1320482092178; Sat, 05 Nov 2011 01:34:52 -0700 (PDT) Received: by 10.182.17.232 with HTTP; Sat, 5 Nov 2011 01:34:52 -0700 (PDT) In-Reply-To: <4EB49E46.2090608@redhat.com> References: <4EB2EACC.8050307@redhat.com> <4EB47B07.7090203@redhat.com> <4EB49E46.2090608@redhat.com> Date: Sat, 05 Nov 2011 09:11:00 -0000 Message-ID: Subject: Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff From: Richard Guenther To: Richard Henderson Cc: Aldy Hernandez , gcc-patches , Torvald Riegel Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg00702.txt.bz2 On Sat, Nov 5, 2011 at 3:24 AM, Richard Henderson wrote: > On 11/04/2011 04:53 PM, Aldy Hernandez wrote: >>> Why is it necessary to know whether a clone is a tm clone? >> >> How do you mean? =A0First, there are a few pretty printing places where = we dump that a function is a clone. =A0It is easy to debug dumps when you k= now which function is the clone and which is the original function, since w= e will dump both variants at code generation time. >> >> Second, there is code in the TM lowering bits where we assert that we ar= e not trying to lower TM clones ahead of time. =A0And there is a check in g= ate_tm_init() where we specify that the entire function is a TM region if i= t is a clone. >> >> etc, etc. >> >> Does this answer your question? > > Richi, if it's the use of the bit in the tree node that you're worried ab= out, > we could probably put it in cgraph_node.local instead. =A0But we do need = the > knowledge. Yeah, I was worried about /* 1 bit left */ ;) Putting it in the cgraph node sounds more appealing indeed. Thanks, Richard. > > r~ >