From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id A5DCC38582BD for ; Wed, 2 Aug 2023 08:05:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A5DCC38582BD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2b9cdbf682eso80537451fa.2 for ; Wed, 02 Aug 2023 01:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690963549; x=1691568349; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1NlUEfXt7kvVZ85LR9lnLSVEfKeorXwZqxFthSrkBNI=; b=j1YEDz17zlkpvQKDbeIw6VvNyb2DNO4uwxJcyIQ1+m197q1nPWVBttBSYAA/IdASpT CNlAwkUrT3aHDnLah87ZIhest5oNlssrhy6WZ6WAQlP6D2Y8HfmPMEW4uOMHHhp5/LVu 3HG83Eecff1OmaWkhuYdclGgvPAONmE9IwxUzS/ymmubaRQMMI0fMHa5fQ0yaktl688b 88/cPUuwDkbQmE67KRchcVUn1F1FScVkxbgDhw5VnO7G/JgU+faWDdvunM9vYSblgWo4 pqUmCbu7v3m07upKY7/OQNUsZAoAlcvZCJtOYSt6hNNlNrFhG1hmXGvHjdNGUGmn+Qh4 EQ6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690963549; x=1691568349; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1NlUEfXt7kvVZ85LR9lnLSVEfKeorXwZqxFthSrkBNI=; b=jrcLLlejn0KOuU+RamWopsOIHZK7p4lZwmXvomubiene8/AvbtFc1hCXbDWnZENX20 4YV2quhVkH+R88T7FOz3vTecp1VTRkmlZ+b4Kmukmcw5//f8iQioA/m0N7mQfO8+0Uko gZ6IJd6Ox+8fpYIeWnTrVX6MOc+ylJjT69yAi8rYu1PZUnjlEqcHZg91qpXRCvG6tkiT cv7ZyuJy+Nno2PwgIXZgBct4rwCLN0zgsn/v6RtW/kcvKwK7uYVQggFbQkm6hlf3Tfsk 6Xd7Dsox3VIc8KDzxAi5IvGCENWkp74cds3njVb5Sw1bkSi/BuS4Sh6WA5lPgORe6bvs IavQ== X-Gm-Message-State: ABy/qLYQd9GVHiaADHfIkHMw+xonGLSgPIlIMKGSG14FLR+5KEcHxA4v uW4xi/VzmmIGrSsm/xhyrbyMABjEnROBHO9vwPA= X-Google-Smtp-Source: APBJJlFidGPVu1eoJ+slMhyxUOUYLTlQoXRCiVxur/h3AN8SQf/9T9L4freDTZcfduaqAO4oeOasB7H/QcN3cw87n0Y= X-Received: by 2002:a05:651c:106:b0:2b6:ded8:6fc1 with SMTP id a6-20020a05651c010600b002b6ded86fc1mr4319367ljb.25.1690963548954; Wed, 02 Aug 2023 01:05:48 -0700 (PDT) MIME-Version: 1.0 References: <20230731174606.2132534-1-apinski@marvell.com> <20230731174606.2132534-2-apinski@marvell.com> In-Reply-To: <20230731174606.2132534-2-apinski@marvell.com> From: Richard Biener Date: Wed, 2 Aug 2023 10:04:54 +0200 Message-ID: Subject: Re: [PATCH 2/2] Slightly improve bitwise_inverted_equal_p comparisons To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jul 31, 2023 at 7:47=E2=80=AFPM Andrew Pinski via Gcc-patches wrote: > > This slighly improves bitwise_inverted_equal_p > for comparisons. Instead of just comparing the > comparisons operands also valueize them. > This will allow ccp and others to match the 2 comparisons > without an extra pass happening. > > OK? Bootstrapped and tested on x86_64-linux-gnu. OK. > gcc/ChangeLog: > > * gimple-match-head.cc (gimple_bitwise_inverted_equal_p): Valueiz= e > the comparison operands before comparing them. > --- > gcc/gimple-match-head.cc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gcc/gimple-match-head.cc b/gcc/gimple-match-head.cc > index 0265e55be93..b1e96304d7c 100644 > --- a/gcc/gimple-match-head.cc > +++ b/gcc/gimple-match-head.cc > @@ -319,12 +319,12 @@ gimple_bitwise_inverted_equal_p (tree expr1, tree e= xpr2, tree (*valueize) (tree) > && TREE_CODE_CLASS (gimple_assign_rhs_code (a1)) =3D=3D tcc_compar= ison > && TREE_CODE_CLASS (gimple_assign_rhs_code (a2)) =3D=3D tcc_compar= ison) > { > - tree op10 =3D gimple_assign_rhs1 (a1); > - tree op20 =3D gimple_assign_rhs1 (a2); > + tree op10 =3D do_valueize (valueize, gimple_assign_rhs1 (a1)); > + tree op20 =3D do_valueize (valueize, gimple_assign_rhs1 (a2)); > if (!operand_equal_p (op10, op20)) > return false; > - tree op11 =3D gimple_assign_rhs2 (a1); > - tree op21 =3D gimple_assign_rhs2 (a2); > + tree op11 =3D do_valueize (valueize, gimple_assign_rhs2 (a1)); > + tree op21 =3D do_valueize (valueize, gimple_assign_rhs2 (a2)); > if (!operand_equal_p (op11, op21)) > return false; > if (invert_tree_comparison (gimple_assign_rhs_code (a1), > -- > 2.31.1 >