public inbox for
 help / color / mirror / Atom feed
From: Richard Biener <>
To: "Bin.Cheng" <>
Cc: "" <>
Subject: Re: [PATCH GCC][4/6]Relax minimal segment length of DR_B for merging alias check
Date: Tue, 30 May 2017 11:29:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, May 25, 2017 at 5:16 PM, Bin.Cheng <> wrote:
> On Tue, May 23, 2017 at 5:23 PM, Bin Cheng <> wrote:
>> Hi,
>> As commented in,
>> We can relax minimal segment length of DR_B for merging.  With this change,
>> the new test can be improved to only one alias check.  Note the
>> condition is still accurate after this patch, it won't introduce false
>> alias.
>> Bootstrap and test on x86_64 and AArch64, is it OK?
> Updated patch wrto change of previous patch.
> Bootstrap and test on x86_64 and AArch64.

Please omit unnecessary braces.  Ok with that change.

Note that

          if (tree_fits_uhwi_p (dr_b1->seg_len))
              min_seg_len_b = dr_b1->seg_len;
              if (tree_int_cst_sign_bit (dr_b1->seg_len))
                min_seg_len_b = wi::neg (min_seg_len_b);

the tree_fits_uhwi_p check is somewhat bogus now that min_seg_len_b is
a wide-int.
It should probably be changed to TREE_CODE (dr_b1->seg_len) == INTEGER_CST
which also means  that

              min_seg_len_b = wi::abs (dr_b1->seg_len);

should work.


> Thanks,
> bin
>> 2017-05-22  Bin Cheng  <>
>>         * tree-data-ref.c (prune_runtime_alias_test_list): Relax minimal
>>         segment length for dr_b.
>> gcc/testsuite/ChangeLog
>> 2017-05-22  Bin Cheng  <>
>>         * gcc.dg/vect/pr80815-3.c: New test.

  reply	other threads:[~2017-05-30 11:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 17:06 Bin Cheng
2017-05-25 15:18 ` Bin.Cheng
2017-05-30 11:29   ` Richard Biener [this message]
2017-05-30 15:34     ` Bin.Cheng
2017-05-31  7:33       ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).