From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com
 [IPv6:2607:f8b0:4864:20::f2c])
 by sourceware.org (Postfix) with ESMTPS id 572CF3858D39
 for <gcc-patches@gcc.gnu.org>; Fri,  1 Jul 2022 06:38:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 572CF3858D39
Received: by mail-qv1-xf2c.google.com with SMTP id t16so3252808qvh.1
 for <gcc-patches@gcc.gnu.org>; Thu, 30 Jun 2022 23:38:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=fzGeXE7lQdntgt7348aKO6BdgRVQp0Y9MeGzfbfJOBU=;
 b=1h4IQgcsCceKwkm5DvXPVxFB4E36432Jxg0Dvb/dvAcAV7ImW0GFpghOHum7WsL7VX
 8hLlT0VnwQpGJt1Pt25OAbAkjBAcCA8vs/gvkARXP0832I4BL85tjaMYpJK4wE7G1hIt
 oFP8JqeD1MyfbXrQXNlnCvYcPanVg+JU+wUDtrfP2OViMRQdCZz/xuKK308lXYsNf1NM
 Kj2caKrNW6czXf/LRXp3ay1OT2Q8lOfH3OE2QyZdkb0dX1uiEWWBh8lU7CcDRAfrnEDl
 rXOBnWms5yn9y1l9uotNFFof6869DRxSRsXlPbeh0+VYdqnZXBO3Ryb7xtp2JN2Yvn1E
 NxbA==
X-Gm-Message-State: AJIora8ZYM7wxrAwc/sCCXJHhOaHHc7yRup8wpmZU8+V+DoQkPDftYjR
 gXgmIIbV2Vd0S5C1HWvvxBuXjpNGP7D8/5fxGR6TQq+n
X-Google-Smtp-Source: AGRyM1srL0r8pO0V+l9Kl9sA6vsC4pHcCc4X2Qg90m0Ux2nhSufLmVsBz2dVIB9042s0/YnyBKW2KA+0Sj3YMjixuF0=
X-Received: by 2002:a05:6214:2129:b0:470:396d:19c4 with SMTP id
 r9-20020a056214212900b00470396d19c4mr14949956qvc.34.1656657489664; Thu, 30
 Jun 2022 23:38:09 -0700 (PDT)
MIME-Version: 1.0
References: <2108030.irdbgypaU6@fomalhaut>
In-Reply-To: <2108030.irdbgypaU6@fomalhaut>
From: Richard Biener <richard.guenther@gmail.com>
Date: Fri, 1 Jul 2022 08:37:58 +0200
Message-ID: <CAFiYyc2KXok_mH9WGHcRaAUky5_-4_g38Daz4g3s6cr6SPNpgw@mail.gmail.com>
Subject: Re: [PATCH] Amend fix for PR middle-end/105874
To: Eric Botcazou <botcazou@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jul 2022 06:38:11 -0000

On Thu, Jun 30, 2022 at 1:34 PM Eric Botcazou via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> As pointed out by Richard, it's very likely too big of a hammer.
>
> Bootstrapped/regtested on x86-64/Linux, OK for the mainline?

LGTM

>
> 2022-06-30  Eric Botcazou  <ebotcazou@adacore.com>
>
>         PR middle-end/105874
>         * expr.cc (expand_expr_real_1) <normal_inner_ref>: Force
>         EXPAND_MEMORY for the expansion of the inner reference only
>         in the usual cases where a memory reference is required.
>
> --
> Eric Botcazou