From: Richard Biener <richard.guenther@gmail.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: Martin Jambor <mjambor@suse.cz>,
GCC Patches <gcc-patches@gcc.gnu.org>,
alan.lawrence@arm.com
Subject: Re: [patch] Fix PR tree-optimization/70884
Date: Fri, 20 May 2016 09:32:00 -0000 [thread overview]
Message-ID: <CAFiYyc2L05fTKEcf0SS9ysnFF0Vn-SntBw4s0rKp4J0g7uOCDg@mail.gmail.com> (raw)
In-Reply-To: <1654126.nIsqskhxhe@polaris>
On Fri, May 20, 2016 at 9:34 AM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> Effectively, the patch prevents late-SRA from doing anything for both
>> testcases (PR 70884 and PR 70919). I have started a bootstrap and
>> testing on x86_64 and i686 only a few moments ago but it would be
>> great if someone also tried on an architecture for which the
>> constant-pool SRA enhancement was intended, just to be sure.
>
> Can you apply it now? It's a wrong-code regression on the 6 branch and people
> can still chime it later in any case.
The patch is ok if it passed bootstrap/regtest. I believe at least on
ARM we had
some tree-ssa.exp testcase(s) that were no longer XFAILing with the
added support.
Thanks,
Richard.
> --
> Eric Botcazou
prev parent reply other threads:[~2016-05-20 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-07 21:22 Eric Botcazou
2016-05-09 10:02 ` Richard Biener
2016-05-13 11:01 ` Eric Botcazou
2016-05-13 11:52 ` Richard Biener
2016-05-13 15:24 ` Martin Jambor
2016-05-20 7:34 ` Eric Botcazou
2016-05-20 9:32 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc2L05fTKEcf0SS9ysnFF0Vn-SntBw4s0rKp4J0g7uOCDg@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=alan.lawrence@arm.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).