Re: [PATCH] c/c++: Tweak warning for 'always_inline function might not be inlinable'

[Richard Biener <richard.guenther@gmail.com>]

On Mon, Jan 22, 2024 at 3:27 PM Hans-Peter Nilsson <hp@axis.com> wrote:
>
> > From: Richard Biener <richard.guenther@gmail.com>
> > Date: Mon, 22 Jan 2024 08:33:47 +0100
>
> > > -                   "%<always_inline%> function might not be inlinable");
> > > +                   "%<always_inline%> function is not always inlined"
> > > +                   " unless also declared %<inline%>");
> >
> > I don't like the "is not always inlined", maybe simply reword to
> >
> >   "%<always_inline%> function might not be inlinable"
> >   " unless also declared %<inline%>"
> >
> > ?
>
> Sure.  Though it's a small nuance to which I don't actually
> agree, I'll go along with almost anything as long as the
> "<unless>...declared inline" augmentation is there :-)
>
> Also, I can see that keeping closer to the original wording
> as you suggest can be preferable to some.
>
> I assume by your reply that the patch is ok with that change
> but will wait another 72 hours for "native speakers" to have
> a say.

Yeah, it's OK with me with that change.  I CCed Honza in case
he has anything to add on the factual side.

Richard.

>
> Thanks!
>
> brgds, H-P