From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 81DF23858D20 for ; Tue, 23 Jan 2024 07:26:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81DF23858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 81DF23858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705994818; cv=none; b=YEMf/yqeZciPwepgl9FcAFeP1Nsgey5SlSaOv8y5CSlZl5uhn6JnVbwOctGx350Fyf88EFgomHhkJa868eNuftjAnL/yxkK1QB7O0Swu0jS8e9tZhljVY0/EJ696PmQogmW/R05HtJ0BGmod3PpRKQs7O4GsL2L7EnQWtLu+1bE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705994818; c=relaxed/simple; bh=B+6YvhRdsBUgt/3OvTQTbQtCEGu7BicBOoCQPXXnYPU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=EoWr8S7e1z2bltUzQjgucslzXWvFfUoLOcPH/u0NcyjEBgdAut49MybX1AX62IYB4iAmq/JPA82lmVayhOuB2t6pkN1o+wi2U5GGdHYsIGxzr0XYpRxeJF6L5WSrokkR6k/hkjMoAuPUhwvRKkZWb04R7ZE3h4mC02Co8IJ5Owg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50e6ee8e911so5359291e87.1 for ; Mon, 22 Jan 2024 23:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705994815; x=1706599615; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jui/3Iz1Jz24SWsiJS17CTS8xGd01r8hqlq1bwHofOE=; b=m/dT3fCR4WBxLB9bj34Al6eIbnwVGJUyctxK1WLrk87oso8Tw5s3/3/1TPAQJP7OMu zyTfGpWsHM/go5FY+U1ZbkfObI5jvw93B+HmKChO4WepRVs0b2zRmZnQm9kl6CHOV2wJ J00UWdd+p4MvPhmX8xq66DPEzX0GRW49QW5mRf0Ib9vXMu5bdRjX0A5qbWvfzrSaR4vl 1pkr+RS5Ifb15pjtXlu1RbdjBz7/5IW2qFh3LoDLCyHSTTovNFcw3A1BcxqesamLtXrm scO3wBnkQ5XT41UOQsnSjUZAXFw/eROudWXWZXVafPAPwnzVE7+ZQiKWG2MoUR8tMmSR F44A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705994815; x=1706599615; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jui/3Iz1Jz24SWsiJS17CTS8xGd01r8hqlq1bwHofOE=; b=rznKd6a//tr+Cu93rR/hRtH8xPBlIjRb4LuVHVOfMGkGpEjrqCJlkqHokNfYsYrXQ5 p4dZ05iZv0FIwL1nGqroH0BvaY1uXO5xFRQAVpuCQx55xOQ4WQfwqcw7sfh5IQPG+ND+ hHEcEdUQMHXYQjUPBfwMqQjaJABDd4mgMx/0bdPHmH090Jr9eHieHbGgz5m0oDJ3zkwW T2owRgVnAqrEfXB0CwF33qJC47nkkeMRNmErRs8ANp/GaALulrlha1pMNyKegxBMc/5k FV0vtdp5dyt0/RT0ovJmQUPN30tjKsD1OdDWcD2/frNU1oL/NPEtDEkLRKFNpuGebqC3 u+cA== X-Gm-Message-State: AOJu0Ywj5b7NZVc5RbgoOmq3XIGTAxqrJN6BnWTet34tGEhcfjQ1TFKz +p84riqqNx43Ox+nV/ScA/+2aWjFKDt3E6DIyov/soIhUbjiaYqgzZpHT9RBvVQNTtmkqq2Fuyl Xb1s1TUhheTQhiEJ4a6mOI6TJll0= X-Google-Smtp-Source: AGHT+IFYFD58JX09tlJeNq7gtR5tZ3x/OPHTWVMUe2CrW+nezGdEoGFvPdnwale+8/mVsGAwohOIiq5o/EoB317mhp8= X-Received: by 2002:a05:6512:a84:b0:50e:b2f0:3dba with SMTP id m4-20020a0565120a8400b0050eb2f03dbamr2706869lfu.15.1705994814734; Mon, 22 Jan 2024 23:26:54 -0800 (PST) MIME-Version: 1.0 References: <20240121133239.45A0B20422@pchp3.se.axis.com> <20240122142716.66B042041E@pchp3.se.axis.com> In-Reply-To: <20240122142716.66B042041E@pchp3.se.axis.com> From: Richard Biener Date: Tue, 23 Jan 2024 08:26:43 +0100 Message-ID: Subject: Re: [PATCH] c/c++: Tweak warning for 'always_inline function might not be inlinable' To: Hans-Peter Nilsson Cc: hubicka@ucw.cz, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 22, 2024 at 3:27=E2=80=AFPM Hans-Peter Nilsson wr= ote: > > > From: Richard Biener > > Date: Mon, 22 Jan 2024 08:33:47 +0100 > > > > - "% function might not be inlinabl= e"); > > > + "% function is not always inlined= " > > > + " unless also declared %"); > > > > I don't like the "is not always inlined", maybe simply reword to > > > > "% function might not be inlinable" > > " unless also declared %" > > > > ? > > Sure. Though it's a small nuance to which I don't actually > agree, I'll go along with almost anything as long as the > "...declared inline" augmentation is there :-) > > Also, I can see that keeping closer to the original wording > as you suggest can be preferable to some. > > I assume by your reply that the patch is ok with that change > but will wait another 72 hours for "native speakers" to have > a say. Yeah, it's OK with me with that change. I CCed Honza in case he has anything to add on the factual side. Richard. > > Thanks! > > brgds, H-P