From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id EBEFA3858015 for ; Tue, 19 Oct 2021 10:55:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EBEFA3858015 Received: by mail-ed1-x52b.google.com with SMTP id a25so11182051edx.8 for ; Tue, 19 Oct 2021 03:55:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4j/7AsyzAZzsBjJANqZJJ2mnpYvHWXnALBy00QufnLs=; b=jJQhIApKYLhJkDWAcrCPj1BWfvv6hkc74kJicUkE4W+FFUKUK1ukRJUQSFCVHDESdl rTo634g7u/Lu1sI1aXscQvpWnkrnUMPKDVlF12/2IHLe3vPnvc6t7P5MPpXIN0HKApH4 1o1jV4sjwQR9kDj7yIXeiO5Ex8iQDqz0+73or1DUUMnr8hRsswlrAiMiOyvldLjKLyZ7 /hKM7WHIYKNR8qWcBOVW1G/kOGJfAG1eY5X3HSHhEQTS6S6QElUdmFHN7rL1Xria5tiW +fMZBOBnfuhU0UepJ8Fuiq6U0fwx6W9UHRrHuQUc1WwQGCIJz4VtB9uCOrQKAuRt7VOs lB3A== X-Gm-Message-State: AOAM5334R07aOrU7tskxTIWbw9qqSFyTHIjDUoNxBkt+uwVYdIdm9Zb6 7LBjHGUEoDjqV72WHR9vOCZk2VTWHkNL5zU+/Rc= X-Google-Smtp-Source: ABdhPJyeoGGBe2rKnrl3qjFfNyEVW7LbxMRVNNQCiDcK0YGWhG70oX1opxaIRYEXCnOVHfVvB+4d7EP0rfp4ur1Mhvs= X-Received: by 2002:a05:6402:1356:: with SMTP id y22mr51615382edw.3.1634640945031; Tue, 19 Oct 2021 03:55:45 -0700 (PDT) MIME-Version: 1.0 References: <20211019084823.444807-1-aldyh@redhat.com> In-Reply-To: <20211019084823.444807-1-aldyh@redhat.com> From: Richard Biener Date: Tue, 19 Oct 2021 12:55:34 +0200 Message-ID: Subject: Re: [COMMITTED] Change threading comment before pass_ccp pass. To: Aldy Hernandez Cc: GCC patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2021 10:55:47 -0000 On Tue, Oct 19, 2021 at 10:48 AM Aldy Hernandez wrote: > > As suggested. Thanks. > > gcc/ChangeLog: > > * passes.def: Change threading comment before pass_ccp pass. > --- > gcc/passes.def | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/gcc/passes.def b/gcc/passes.def > index c11c237f6d2..4c54176328b 100644 > --- a/gcc/passes.def > +++ b/gcc/passes.def > @@ -339,9 +339,7 @@ along with GCC; see the file COPYING3. If not see > NEXT_PASS (pass_thread_jumps); > NEXT_PASS (pass_vrp, false /* warn_array_bounds_p */); > NEXT_PASS (pass_vrp_threader); > - /* Threading can leave many const/copy propagations in the IL. > - Clean them up. Instead of just copy_prop, we use ccp to > - compute alignment and nonzero bits. */ Well, the comment is still true as long as pass_vrp_threader is there ;) > + /* Run CCP to compute alignment and nonzero bits. */ > NEXT_PASS (pass_ccp, true /* nonzero_p */); > NEXT_PASS (pass_warn_restrict); > NEXT_PASS (pass_dse); > -- > 2.31.1 >