From: Richard Biener <richard.guenther@gmail.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>, richard.sandiford@arm.com
Subject: Re: PR 66685: parallel returns being misclassified
Date: Wed, 01 Jul 2015 08:35:00 -0000 [thread overview]
Message-ID: <CAFiYyc2MRO2kmboSkwv-jCcSfs9S4s5J-r-dovC1iECpoBonOw@mail.gmail.com> (raw)
In-Reply-To: <87h9ponuzs.fsf@e105548-lin.cambridge.arm.com>
On Wed, Jul 1, 2015 at 10:27 AM, Richard Sandiford
<richard.sandiford@arm.com> wrote:
> This patch should restore bootstrap on hppa (and probably other targets
> besides). The change to use target-insns.def put more stress on the
> emit()/classify_insn() group of functions, which were missing a case
> for parallel returns.
>
> Tested with a cross-compiler that it fixes the hppa problem. Bootstrap
> in progress on x86_64-linux-gnu. OK to install?
Ok.
Richard.
> Sorry for the slow response on this one. I'd misread the PR and thought
> that it was the bug fixed in r225000.
>
> Thanks,
> Richard
>
>
> gcc/
> PR bootstrap/66685
> * rtl.c (classify_insn): Handle returns in PARALLELs.
>
> Index: gcc/rtl.c
> ===================================================================
> --- gcc/rtl.c 2015-07-01 09:13:29.782160299 +0100
> +++ gcc/rtl.c 2015-07-01 09:13:29.778160333 +0100
> @@ -686,6 +686,8 @@ classify_insn (rtx x)
> for (j = XVECLEN (x, 0) - 1; j >= 0; j--)
> if (GET_CODE (XVECEXP (x, 0, j)) == CALL)
> return CALL_INSN;
> + else if (ANY_RETURN_P (XVECEXP (x, 0, j)))
> + return JUMP_INSN;
> else if (GET_CODE (XVECEXP (x, 0, j)) == SET
> && GET_CODE (SET_DEST (XVECEXP (x, 0, j))) == PC)
> return JUMP_INSN;
>
next prev parent reply other threads:[~2015-07-01 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 8:27 Richard Sandiford
2015-07-01 8:35 ` Richard Biener [this message]
2015-07-01 15:25 ` Richard Sandiford
2015-07-01 16:45 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc2MRO2kmboSkwv-jCcSfs9S4s5J-r-dovC1iECpoBonOw@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).