From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com
 [IPv6:2607:f8b0:4864:20::82d])
 by sourceware.org (Postfix) with ESMTPS id A42583858D32
 for <gcc-patches@gcc.gnu.org>; Thu,  7 Jul 2022 11:45:02 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A42583858D32
Received: by mail-qt1-x82d.google.com with SMTP id ay10so22230034qtb.1
 for <gcc-patches@gcc.gnu.org>; Thu, 07 Jul 2022 04:45:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=6zdfIaJOQzw8l0VoVxhDKxwxXVtVieJJr5dcW+3jUn0=;
 b=FzbNoQozAv/mUHzkeSFT89R2aD9Jl+pdL8s7nB5DLNCdFvL2//eYzOrb+NhEcS65JE
 L6omslwRDHTBy7ZSIaDIhk+aJ86wflnwD8sCAidqVt7NwSiC5dd+qnLFVY2I4HsO7ad1
 wGd8ChyBrk8cvL7thTgB+wy4M364Pq45+rNGpoD7RM4gEPu29iH52orGPsDQRTVepMZT
 xlICzGTudMnbXL7lRXKs7ySFEYHQ95tFI4RVInEBJEbFDNsp14SEPewioen3AIuIVi1v
 mCY1COTpEIERH6+PlVB3qxiqs7yu23ke1ja1C9MJA+SLFV2W5IerLiN4mGMrVwlspB+T
 5sYA==
X-Gm-Message-State: AJIora+Yc6iHOs0lNDnnfmUbREtzFV6zm4graoqfo8CQBxqV3OgcU5HE
 EZ8PtcCTDQOU4HwzGSapn224B9Q6qu2uSVo3qNnYdXnT
X-Google-Smtp-Source: AGRyM1vrZDAJNFTnUSN47OpBDFj8ej9AqdvKS/ko+BiPXH9LVvh74x4tJU0EMx7UnOfUJ7cK5jXnoEdH5rZDQ6Y0H4s=
X-Received: by 2002:a05:622a:4cd:b0:31d:26a1:2536 with SMTP id
 q13-20020a05622a04cd00b0031d26a12536mr36302583qtx.626.1657194301639; Thu, 07
 Jul 2022 04:45:01 -0700 (PDT)
MIME-Version: 1.0
References: <CAAgBjMnynmyAupLFnn7evFhE5T0VOqd5P4XaQhnycER-6FydSw@mail.gmail.com>
In-Reply-To: <CAAgBjMnynmyAupLFnn7evFhE5T0VOqd5P4XaQhnycER-6FydSw@mail.gmail.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Thu, 7 Jul 2022 13:44:50 +0200
Message-ID: <CAFiYyc2OqPboNJ45gcU6QjUxuqSSminD4AG1e76PivoOkC+cPw@mail.gmail.com>
Subject: Re: [statistics.cc] ICE in get_function_name with fortran test-case
To: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE,
 WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jul 2022 11:45:04 -0000

On Thu, Jul 7, 2022 at 12:44 PM Prathamesh Kulkarni
<prathamesh.kulkarni@linaro.org> wrote:
>
> Hi,
> My recent commit to emit asm name with -fdump-statistics-asmname
> caused following ICE
> for attached fortran test case.
>
> during IPA pass: icf
> power.fppized.f90:6:26:
>
>     6 | END SUBROUTINE power_print
>       |                          ^
> internal compiler error: Segmentation fault
> 0xfddc13 crash_signal
>         ../../gcc/gcc/toplev.cc:322
> 0x7f6f940de51f ???
>         ./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
> 0xfc909d get_function_name
>         ../../gcc/gcc/statistics.cc:124
> 0xfc929f statistics_fini_pass_2(statistics_counter**, void*)
>         ../../gcc/gcc/statistics.cc:175
> 0xfc94a4 void hash_table<stats_counter_hasher, false,
> xcallocator>::traverse_noresize<void*,
> &(statistics_fini_pass_2(statistics_counter**, void*))>(void*)
>         ../../gcc/gcc/hash-table.h:1084
> 0xfc94a4 statistics_fini_pass()
>         ../../gcc/gcc/statistics.cc:219
> 0xef12bc execute_todo
>         ../../gcc/gcc/passes.cc:2142
>
> This happens because fn was passed NULL in get_function_name.
> The patch adds a check to see if fn is NULL before checking for
> DECL_ASSEMBLER_NAME_SET_P, which fixes the issue.
> In case the fn is NULL, it calls function_name(NULL) as per old behavior,
> which returns "(nofn)".
>
> Bootstrap+tested on x86_64-linux-gnu.
> OK to commit ?
OK

>
> Thanks,
> Prathamesh