From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48563 invoked by alias); 7 Aug 2019 11:57:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 48555 invoked by uid 89); 7 Aug 2019 11:57:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-lf1-f65.google.com Received: from mail-lf1-f65.google.com (HELO mail-lf1-f65.google.com) (209.85.167.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Aug 2019 11:57:51 +0000 Received: by mail-lf1-f65.google.com with SMTP id x3so10044341lfn.6 for ; Wed, 07 Aug 2019 04:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IkkBOlQe3y8aiDvbEUxnRPTEYz5kOtb0+Pc/R6eLcZc=; b=JNuyVR22HoKFs3x4vV2lYIiL2kSMaDws7a+gRhxuUmOuA+XXKRC12Zj8uyabE6LxpP RRFTwUOYflyyJc4jZZB9pGJLTGt9cuUAGADjYUgFxbi2l+QPvzxXU4wEcQRnFCjuYHVp ccd4k+INRez9PoFu/BTD8y8AsiuM6eA6wBqT5vTMZ3RUTuY4ICvRwd1XSdVASwpUJckd iGB4kixVyIGxScUHBvcyX/v0sU+oLz4ElCEG10q8JqskThbVCd/o/A/TDYy7Z+uUZkA6 yzHzJahq0vu/6/iC0WgB5USuCNFNpdoU4ycEopH5du9teJKVJ0dMBik0DhNw+yLxm8UY rsDQ== MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Wed, 07 Aug 2019 12:05:00 -0000 Message-ID: Subject: Re: [PATCH 4/9] Strengthen alias_ptr_types_compatible_p in LTO mode. To: Martin Liska Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00450.txt.bz2 On Tue, Aug 6, 2019 at 5:43 PM Martin Liska wrote: This warrants a comment like /* This function originally abstracts from simply comparing get_deref_alias_set so that we are sure this still computes the same result after LTO type merging is applied. When in LTO type merging is done we can actually do this compare. */ if (in_lto_p) return get_deref_alias_set (t1) == get_deref_alias_set (t2); ... also note you want to call get_deref_alias_set as mentioned in the function comment. OK with this change. Thanks, Richard. > gcc/ChangeLog: > > 2019-07-24 Martin Liska > > * alias.c (alias_ptr_types_compatible_p): Strengten > type comparison in LTO mode. > --- > gcc/alias.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >