From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b])
	by sourceware.org (Postfix) with ESMTPS id B38DC385840C
	for <gcc-patches@gcc.gnu.org>; Mon, 24 Oct 2022 12:32:42 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B38DC385840C
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ed1-x52b.google.com with SMTP id i21so9562503edj.10
        for <gcc-patches@gcc.gnu.org>; Mon, 24 Oct 2022 05:32:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=4aWRHrqBfULNF4zL5KogqPA2m9W5it9Jgo+hscomOmg=;
        b=ZepUJAX/uy/85stWocxHL7gowgSuF3c6/aJjVxv20iCGH3fE3gaOIDrZpqrHpOsCe9
         vdmzm3Y8B2hEut8zGoYvaB8Q4mtQnuy5YkvHTKzfowlzXvnTUBnnySirqdAZTyMnrXwT
         IG73OI3WlVNjBp76Bphd60cEhwCTdOVoyL/ax+w5Y7XlnBJdlYeyk4N9qtajYceDxyw9
         Ufaf4LQIifdf90rEsa3+2YQbO7bntbP1GZhG9H9ZI6DQRT52FaAvdD4Ov2hCJYhABgGI
         txGRAV1jnUMglGwpU3OAoMio1ocpFGhvI5MfyZlUKP+E7vr7NbqxZ3O2+KNlC5dtLiFy
         28vQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=4aWRHrqBfULNF4zL5KogqPA2m9W5it9Jgo+hscomOmg=;
        b=Dlo77vd517l+z9q7+Pr1SGlgLiRex5RrAMV7ZnnRPqccKfltNQ32of5mV+di8CY6Xf
         Z8C4MkJWcO6fg4eb9lWFL0tdofbOJyQD5dTqctWPoSmP/Z6CCQQnLi//DMopD9jRfCpV
         G3oWwmg3hqVN3fMZzU7s69bR0+vN454bHXFPf00F+FjHm/lEOgWWaeIRy5phixfF0Qm+
         l/1BYYA/0rBKC9wOoFjtCx0qNglsXzQeA8JHwFN1YyI4CceOcZm4AgKbZCQ+ZCVbI1Jx
         xdykzJ7qXbxIiUsVRHPyUmeBJxLvLnTHPb9KF1WbBfldSzTKcZvXeGj2jt2EjKKQuHeD
         qoEA==
X-Gm-Message-State: ACrzQf2u9Y3Qb0V5EnbWzD/X6waiM5lGFcNLPUXv/xtdq0cDHrqexjbb
	FmfNLxeqybQe2uBXPjJ0+aMlVStBY23vDr4mCtA=
X-Google-Smtp-Source: AMsMyM6G20fHwQrd54qsHf06vgXEXI+62S96VY/bS0u56tjK27AaOYVEaliqYt1fsXX3q1CpFuvsv1v/dlOfodJu7ro=
X-Received: by 2002:a17:907:7208:b0:78e:176e:e0c6 with SMTP id
 dr8-20020a170907720800b0078e176ee0c6mr27465919ejc.594.1666614761451; Mon, 24
 Oct 2022 05:32:41 -0700 (PDT)
MIME-Version: 1.0
References: <1910003.PYKUYFuaPT@fomalhaut>
In-Reply-To: <1910003.PYKUYFuaPT@fomalhaut>
From: Richard Biener <richard.guenther@gmail.com>
Date: Mon, 24 Oct 2022 14:32:29 +0200
Message-ID: <CAFiYyc2WydJrz_Jz_7MOs7aDciNeGcqW68Xf3AELpp00B-PDZg@mail.gmail.com>
Subject: Re: [PATCH] Relax assertion in profile.cc
To: Eric Botcazou <botcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Mon, Oct 24, 2022 at 10:26 AM Eric Botcazou via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
>
> this assertion in branch_prob:
>
>   if (bb == ENTRY_BLOCK_PTR_FOR_FN (cfun)->next_bb)
>     {
>       location_t loc = DECL_SOURCE_LOCATION (current_function_decl);
>       gcc_checking_assert (!RESERVED_LOCATION_P (loc));
>
> had been correct until:
>
> 2021-08-11  Bernd Edlinger  <bernd.edlinger@hotmail.de>
>
>         PR debug/101598
>         * gcc-interface/trans.c (Subprogram_Body_to_gnu): Set the
>         DECL_SOURCE_LOCATION of DECL_IGNORED_P gnu_subprog_decl to
>         UNKNOWN_LOCATION.
>
> was installed.
>
> Tested on x86-64/Linux, OK for mainline and 12 branch?

OK.

>
> 2022-10-24  Eric Botcazou  <ebotcazou@adacore.com>
>
>         * profile.cc (branch_prob): Be prepared for ignored functions with
>         DECL_SOURCE_LOCATION set to UNKNOWN_LOCATION.
>
>
> 2022-10-24  Eric Botcazou  <ebotcazou@adacore.com>
>
>         * gnat.dg/specs/coverage1.ads: New test.
>
> --
> Eric Botcazou