From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id C1926385842E for ; Fri, 9 Feb 2024 10:34:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1926385842E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C1926385842E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707474897; cv=none; b=EGgF26Y6Y6BMwk0p+uPyrgF1Kwj+wESydUcI3dim6DH2MifvL9MonfsVt6JQs/a4TtdGvTcMfl/lkq2BprM3QxtJBrBw8vbmZHkeLaoZ7AzA4Hl18eejXqJet729RVTKKYbEKHIFyVOGlbYLPYShVnRFOziRCvZcLqaUznNUG+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707474897; c=relaxed/simple; bh=W1u8m0txWaDO3IjQMzUP1ePzfpTl2jE+ZdmDkIc4y9Q=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=x7tLziVvUK8DWbroZx3nb7dxgBRuEtHthuIyOIgiMdXAgiefJaxlg/Khe+5MQ+piXAyVYynK54uT++Zun/xNM98FY5bcLZ+AIK6I5o3gS0Re4bQ59Uf9Z82fKn+X3laFdzr1j3oD6R0vnWjvX0G5SPUTcG5v1lfQpL07GA1c9N8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-511689cc22aso1225948e87.0 for ; Fri, 09 Feb 2024 02:34:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707474893; x=1708079693; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sa9KnvbLQ1MS9gP8ZgOeQnuPJH9pVONoYxN62O+GovE=; b=F1h6F6CJjXE3MdN9hbEpIP1tXSI6b7U5lLEdhSmIhjuLrdrbXm5BqbAYn625EcWCVH x9rlKJV5dFLie0pDUvOtea6E2F8Rruq4YJT9Zl1iyA+BKy6fNS1xDOP3KD4wsrHi9wr8 ZPhOQG1VFOS+hJxgiFFsLsaFv0EJvbMahprTMPrz4K0JieXLzcm+G+63efcS8Gg7iCsH Z5OjtQikFw1ues5ZXjQvBz6vCz3ezzYNRL6vJAz0hxIBLJXHcj/TLpSHMXS46/6EtxHd NARHdRzmuhqAljBUEhuIzyEzIt+9xE21dImsF846/x3SgV/yHivU2tz57BSyydFAMm9D KsRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707474893; x=1708079693; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sa9KnvbLQ1MS9gP8ZgOeQnuPJH9pVONoYxN62O+GovE=; b=UHIJcOYOn+7YlpcsYIOs4/M5jj5hHojROodTuBVXG0KujQU7zrvK6LzHxoEC/BEYTm 6o8lDP5dT0xtSMbjN1krSOzcguMKBdf+ibtRFMcvPUgjLq3N1WDumXhOkdKjgxsDkgUJ yAHuhEag0PmVyGV3/5fHLwmvRky8RXE+obeMAby2qOMkvOOiVRO5gSattg5+bSSPste0 vekFJdH6bzEtXRqs79+lfjOJ3WirbHJgntrQRD+FY/awZaUqv7R+FBSvGNkw+Qg6YiRM 5Wi1VcixUlXTLr5ykkwXVkn04udfS/Al/qQ9nAlbM6EKEGgKuorOSic+aWqmD4rrGwzZ v0sQ== X-Forwarded-Encrypted: i=1; AJvYcCWqDbxSqtbuDr43NBaWOK3xoDIe2+VEOLqNOaMshV7bPGbpKwluP4ni1ef50jN7/LR6Qyjn0W15M+fk8TOdzapKjO2i5OYF+A== X-Gm-Message-State: AOJu0YzSDI/ZO8N5nxKB1f29UwqDpvLY3kPp0tSBhTj1kRWtzurz9LyK yDqOseYJlFl3fsGWWek0FcTjMm7RwmVcoTO4QJqGBi3KrINZbjpLB+IX023yW2oDxJLIQr7MVd2 Xvg2tg0zxKjsRjsOc2Bkq8vCOAp8= X-Google-Smtp-Source: AGHT+IHcS9TelYLE4edcyjMnv/zUA//3jqBwNtp4ZNAHvVyaq3hknNZwevWSCX2vIUR6X/x9FumUU5FLl2mFGJ0KcRU= X-Received: by 2002:ac2:5196:0:b0:511:4efa:3836 with SMTP id u22-20020ac25196000000b005114efa3836mr750851lfi.49.1707474893188; Fri, 09 Feb 2024 02:34:53 -0800 (PST) MIME-Version: 1.0 References: <8454e29d-ae16-48bf-9cbd-eadec0a6a4a8@foss.st.com> In-Reply-To: <8454e29d-ae16-48bf-9cbd-eadec0a6a4a8@foss.st.com> From: Richard Biener Date: Fri, 9 Feb 2024 11:34:41 +0100 Message-ID: Subject: Re: [PATCH] [testsuite] tsvc: skip include malloc.h when unavailable To: Torbjorn SVENSSON Cc: Alexandre Oliva , gcc-patches@gcc.gnu.org, Rainer Orth , Mike Stump , Yvan Roux Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 9, 2024 at 11:33=E2=80=AFAM Torbjorn SVENSSON wrote: > > Hi, > > Is it okay to backport 2f20d6296087cae51f55eeecb3efefe786191fd6 to > releases/gcc-13? Yes. > Without this backport, I see about 150 failures on arm-none-eabi, an > example of them is: > > FAIL: gcc.dg/vect/tsvc/vect-tsvc-s000.c (test for excess errors) > > > Kind regards, > Torbj=C3=B6rn > > On 2023-05-24 11:02, Richard Biener via Gcc-patches wrote: > > On Wed, May 24, 2023 at 7:17=E2=80=AFAM Alexandre Oliva via Gcc-patches > > wrote: > >> > >> > >> tsvc tests all fail on systems that don't offer a malloc.h, other than > >> those that explicitly rule that out. Use the preprocessor to test for > >> malloc.h's availability. > >> > >> tsvc.h also expects a definition for struct timeval, but it doesn't > >> include sys/time.h. Add a conditional include thereof. > >> > >> Bootstrapped on x86_64-linux-gnu. Also tested on ppc- and x86-vx7r2 > >> with gcc-12. > > > > OK. > > > >> > >> for gcc/testsuite/ChangeLog > >> > >> * gcc.dg/vect/tsvc/tsvc.h: Test for and conditionally include > >> malloc.h and sys/time.h. > >> > >> --- > >> gcc/testsuite/gcc.dg/vect/tsvc/tsvc.h | 5 ++++- > >> 1 file changed, 4 insertions(+), 1 deletion(-) > >> > >> diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/tsvc.h b/gcc/testsuite/gcc= .dg/vect/tsvc/tsvc.h > >> index 75494c24cfa62..cd39c041903dd 100644 > >> --- a/gcc/testsuite/gcc.dg/vect/tsvc/tsvc.h > >> +++ b/gcc/testsuite/gcc.dg/vect/tsvc/tsvc.h > >> @@ -11,9 +11,12 @@ > >> > >> #include > >> #include > >> -#if !defined(__APPLE__) && !defined(__DragonFly__) > >> +#if __has_include() > >> #include > >> #endif > >> +#if __has_include() > >> +#include > >> +#endif > >> #include > >> #include > >> > >> > >> -- > >> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/l= xo/ > >> Free Software Activist GNU Toolchain Enginee= r > >> Disinformation flourishes because many people care deeply about injust= ice > >> but very few check the facts. Ask me about