From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com
 [IPv6:2a00:1450:4864:20::535])
 by sourceware.org (Postfix) with ESMTPS id 0FB8F3858D39
 for <gcc-patches@gcc.gnu.org>; Tue,  5 Oct 2021 11:32:12 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0FB8F3858D39
Received: by mail-ed1-x535.google.com with SMTP id l7so53733642edq.3
 for <gcc-patches@gcc.gnu.org>; Tue, 05 Oct 2021 04:32:12 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=z3HMXiCLUHOLjChSok/k0qRD60XyCNpD3MrHQ5fPzuk=;
 b=mEdooA5xD5lCcV8j9AQtBczHTI4Z6JFfL6bZ7gpRCfzTkwFhD9R6MaK68UpgZ+BBIm
 sw98nHa0i0COrsnTQwJhf13JwuwBxQmFRkXuhgs+2i/o3JIWJz3Ykjgfjif0OXay3MwZ
 KEcBhnpwH92qb6wV3wYTFED2u45aJqddk/cbZKjKiDljo+BHONvZc9SvgZ3Tu8eLaQX0
 JO4JCx8o6CKR+T2JnSwx1/Jl17NB0VWejK52SUPdG/RlYhoVp2AzvEhHS3J2Tvmf39ax
 tKn3fuKtX4xhVDb6nV3yYGW7RmhQ8MqsfgP1fSyPPGjy3HmdeAhvmEo3ugM23opH9Xnu
 lnhg==
X-Gm-Message-State: AOAM533qTXlrLf4LHMljjRWAvfz4R7gR6E4Z9WG31/N2zqioTTKiaOrD
 cIgqlWB19zHhIgA7FuCxYpQT6YFp/PlXfPbOz5C5Iu2k
X-Google-Smtp-Source: ABdhPJxI3PJb5byjvEVHZAxLJEzwPQ8FLaQUePUw0JyIkoEbdGOiSOr0GmWHeqHM9xgog4TgmSc+4lvoXfCYLAuosr8=
X-Received: by 2002:a05:6402:2790:: with SMTP id
 b16mr25108836ede.3.1633433531122; 
 Tue, 05 Oct 2021 04:32:11 -0700 (PDT)
MIME-Version: 1.0
References: <CAAgBjMm+eyuWWbnYuE5ezSJOKj=x240Octf1HgG=MDUB-1p1+g@mail.gmail.com>
In-Reply-To: <CAAgBjMm+eyuWWbnYuE5ezSJOKj=x240Octf1HgG=MDUB-1p1+g@mail.gmail.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Tue, 5 Oct 2021 13:32:00 +0200
Message-ID: <CAFiYyc2cBEXBziKyuG1orpCf_UpLCAT1ukOSaEzqFANCgJQfbQ@mail.gmail.com>
Subject: Re: [gimple-isel] Remove redundant if condition
To: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Oct 2021 11:32:13 -0000

On Tue, Oct 5, 2021 at 9:11 AM Prathamesh Kulkarni via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
> In gimple_expand_vec_cond_expr:
>
>   icode = get_vcond_icode (mode, cmp_op_mode, unsignedp);
>   if (icode == CODE_FOR_nothing)
>     {
>       if (tcode == LT_EXPR
>           && op0a == op0)
>         {
>           /* A VEC_COND_EXPR condition could be folded from EQ_EXPR/NE_EXPR
>              into a constant when only get_vcond_eq_icode is supported.
>              Try changing it to NE_EXPR.  */
>           tcode = NE_EXPR;
>         }
>       if ((tcode == EQ_EXPR || tcode == NE_EXPR)
>           && direct_internal_fn_supported_p (IFN_VCONDEQ, TREE_TYPE (lhs),
>                                              TREE_TYPE (op0a),
>                                              OPTIMIZE_FOR_BOTH))
>         {
>           tree tcode_tree = build_int_cst (integer_type_node, tcode);
>           return gimple_build_call_internal (IFN_VCONDEQ, 5, op0a, op0b, op1,
>                                              op2, tcode_tree);
>         }
>     }
>
>   if (icode == CODE_FOR_nothing)
>     {
>       gcc_assert (VECTOR_BOOLEAN_TYPE_P (TREE_TYPE (op0))
>                   && can_compute_op0
>                   && (get_vcond_mask_icode (mode, TYPE_MODE (TREE_TYPE (op0)))
>                       != CODE_FOR_nothing));
>       return gimple_build_call_internal (IFN_VCOND_MASK, 3, op0, op1, op2);
>     }
>
> It seems the second check for icode == COND_FOR_nothing is redundant,
> since icode is not reassigned in the previous block ?
> The attached patch removes the second if condition.
> OK to commit after bootstrap+test ?
>
OK.

> Thanks,
> Prathamesh