From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-455804-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 30047 invoked by alias); 13 Jun 2017 11:08:37 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 30033 invoked by uid 89); 13 Jun 2017 11:08:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:74.125.82.194, H*RU:74.125.82.194, life
X-HELO: mail-ot0-f194.google.com
Received: from mail-ot0-f194.google.com (HELO mail-ot0-f194.google.com) (74.125.82.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 11:08:31 +0000
Received: by mail-ot0-f194.google.com with SMTP id t31so13745909ota.2        for <gcc-patches@gcc.gnu.org>; Tue, 13 Jun 2017 04:08:36 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=BNJ0AY75+y5LBBNLn5MrA8HJuuvhDTOYpwNH9QhylQ4=;        b=EuSsZIXdttnKl+x9++iPLaSBSuUiN7zP26fKtWVKSFf0IeoobpflhXf7a3nVP5G4V7         7rvTS0HS+19DW64o4Er0dTQnvOBvdMuO5zV9fgmpBPiRiJO9xb5eTdhRyER/IZwmSoek         wpqVKVJwDF5nteH/6Jww5BAV7UioSIe8LpEpOauedNaKz/QooRmORLIlzFvU8bQ0rz6w         cJzViocP5AySD/qIq4/TNwWSFy79O4T64b8oeLnl9VDMbL4/5FCztw/sU1n00OU5QKpR         athoCYcuSh/PhoHfpZ9I3UNRZccsAdwgkL5pPqKkfA+FqvIKKaeMVMouBexBX6jWCgDw         LQqQ==
X-Gm-Message-State: AKS2vOytDn5HYqZu3nUCtlbXsq1WAPyjtBdeas138fk6Qfse21V+xIBJ	Rx3iSsfHOytwfPELG5BxlXM9bYvB1A==
X-Received: by 10.157.28.134 with SMTP id l6mr28985565ota.87.1497352114841; Tue, 13 Jun 2017 04:08:34 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.157.36.8 with HTTP; Tue, 13 Jun 2017 04:08:34 -0700 (PDT)
In-Reply-To: <CAFiYyc1sncfmYBdH6Cb8zda8nxUiPuXzhUcmAh_EOnz-7eqgBQ@mail.gmail.com>
References: <VI1PR0802MB21768DDC39759A94BC4F2A54E7CD0@VI1PR0802MB2176.eurprd08.prod.outlook.com> <CAFiYyc1sncfmYBdH6Cb8zda8nxUiPuXzhUcmAh_EOnz-7eqgBQ@mail.gmail.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Tue, 13 Jun 2017 11:08:00 -0000
Message-ID: <CAFiYyc2d_Azow+f80_os+P3_DQ+g8jYbwa7mAyw_OfNhHDtw2g@mail.gmail.com>
Subject: Re: [PATCH GCC][06/13]Preserve loop nest in whole distribution life time
To: Bin Cheng <Bin.Cheng@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2017-06/txt/msg00899.txt.bz2

On Tue, Jun 13, 2017 at 1:06 PM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Mon, Jun 12, 2017 at 7:02 PM, Bin Cheng <Bin.Cheng@arm.com> wrote:
>> Hi,
>> This simple patch computes and preserves loop nest vector for whole distribution
>> life time.  The loop nest will be used multiple times in on-demand data dependence
>> computation.
>>
>> Bootstrap and test on x86_64 and AArch64.  Is it OK?
>
> Don't like it too much but I guess we can see if refactoring it back
> to pass down
> loop_nest can work.
>
> Ok.

Oh.

+/* The loop (nest) to be distributed.  */
+static vec<loop_p> *loop_nest;
+

please make it

static vec<loop_p> loop_nest;

instead to avoid a pointless indirection (vec<> just contains a
pointer to allocated storage).

Richard.

> Thanks,
> Richard.
>
>> Thanks,
>> bin
>> 2017-06-07  Bin Cheng  <bin.cheng@arm.com>
>>
>>         * tree-loop-distribution.c (loop_nest): New global var.
>>         (build_rdg): Use loop directly, rather than loop nest.
>>         (pg_add_dependence_edges): Remove loop nest parameter.  Use global
>>         variable directly.
>>         (distribute_loop): Compute global variable loop nest.  Update use.