From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 5A16F3858413 for ; Thu, 18 Aug 2022 07:31:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A16F3858413 Received: by mail-ej1-x62e.google.com with SMTP id fy5so1704204ejc.3 for ; Thu, 18 Aug 2022 00:31:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=1eiCFZUoV5kGHqYtuBOay4lK4T7lGCvGSDxpJHOuQfo=; b=2FPJq5FvaIDXlU001dKPuBVHjk/L0sR9iTpcfn7FeIJcTFApSf0Hvz1GvJmCeduvHI dFeXXEOLIwjIvKbsRYMMy7JSJfWQsqtiDBEt/8j4j3D/NR7qHhPvNcNHQI+xrYEB45CE kq/MZAU2IZKp45j94I84rm6abTdWyvVz4IbH9RRLALncaTDCxSnRuJIMgfCVeJl5oqKP pfAelk5Z+XUkfRiGV8Or7xld3UvqQKk87VYd2+v7+BmiYaNHUgtib39HxwujML1a4w35 abdhuCTN89IpOh0SAsP7YkoKgqTcM1cBBmOqT5TdRf7dKJcq7B2PfBOLfAs6uzTSFIoD wb2g== X-Gm-Message-State: ACgBeo356Xs+6FNhC4KAEvlfEF7gbhQ2H/KIMQ9gD9exWGaZbhBc3crR wvC25GPQUzXsmsqA7oM72LO7MOK6FawXxoZAfP3s5QjV X-Google-Smtp-Source: AA6agR60huj/UyrQ9bmVgB4EZCL4NgGb2SWuyd/RQ5C3zXaMY4y8xWy1DhlZQZoiIHL2Npl/9rFeJpcnd2IRcPbOCJM= X-Received: by 2002:a17:907:9712:b0:731:67db:1b48 with SMTP id jg18-20020a170907971200b0073167db1b48mr1107414ejc.754.1660807894021; Thu, 18 Aug 2022 00:31:34 -0700 (PDT) MIME-Version: 1.0 References: <20220817134750.1859249-1-stefansf@linux.ibm.com> In-Reply-To: <20220817134750.1859249-1-stefansf@linux.ibm.com> From: Richard Biener Date: Thu, 18 Aug 2022 09:31:21 +0200 Message-ID: Subject: Re: [PATCH] Add further FOR_EACH_ macros To: Stefan Schulze Frielinghaus Cc: Martin Liska , GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UPPERCASE_75_100 autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2022 07:31:37 -0000 On Wed, Aug 17, 2022 at 3:56 PM Stefan Schulze Frielinghaus via Gcc-patches wrote: > > For my current use case only some FOR_EACH_MODE macros were missing. > Though I thought I will give it a try and grep'ed through the source > code and added further ones. I didn't manually check all of them but so > far it looks good to me. > > Ok for mainline? OK > > contrib/ChangeLog: > > * clang-format: Add further FOR_EACH_ macros. > --- > contrib/clang-format | 63 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > > diff --git a/contrib/clang-format b/contrib/clang-format > index ceb5c1d524f..57cec1e6947 100644 > --- a/contrib/clang-format > +++ b/contrib/clang-format > @@ -63,17 +63,33 @@ ForEachMacros: [ > 'FOR_BB_INSNS_SAFE', > 'FOR_BODY', > 'FOR_COND', > +'FOR_EACH_2XWIDER_MODE', > +'FOR_EACH_ACTUAL_CHILD', > 'FOR_EACH_AGGR_INIT_EXPR_ARG', > 'FOR_EACH_ALIAS', > 'FOR_EACH_ALLOCNO', > +'FOR_EACH_ALLOCNO_CONFLICT', > +'FOR_EACH_ALLOCNO_IN_ALLOCNO_SET', > 'FOR_EACH_ALLOCNO_OBJECT', > 'FOR_EACH_ARTIFICIAL_DEF', > 'FOR_EACH_ARTIFICIAL_USE', > +'FOR_EACH_BB', > 'FOR_EACH_BB_FN', > +'FOR_EACH_BB_IN_BITMAP', > +'FOR_EACH_BB_IN_BITMAP_REV', > +'FOR_EACH_BB_IN_REGION', > +'FOR_EACH_BB_IN_SBITMAP', > +'FOR_EACH_BB_REVERSE', > 'FOR_EACH_BB_REVERSE_FN', > +'FOR_EACH_BB_REVERSE_IN_REGION', > 'FOR_EACH_BIT_IN_MINMAX_SET', > +'FOR_EACH_BSI_IN_REVERSE', > 'FOR_EACH_CALL_EXPR_ARG', > +'FOR_EACH_CHILD', > 'FOR_EACH_CLONE', > +'FOR_EACH_CODE_MAPPING', > +'FOR_EACH_COND_FN_PAIR', > +'FOR_EACH_CONFLICT', > 'FOR_EACH_CONST_CALL_EXPR_ARG', > 'FOR_EACH_CONSTRUCTOR_ELT', > 'FOR_EACH_CONSTRUCTOR_VALUE', > @@ -83,16 +99,27 @@ ForEachMacros: [ > 'FOR_EACH_DEFINED_SYMBOL', > 'FOR_EACH_DEFINED_VARIABLE', > 'FOR_EACH_DEP', > +'FOR_EACH_DEP_LINK', > 'FOR_EACH_EDGE', > +'FOR_EACH_ELEMENT', > +'FOR_EACH_ELIM_GRAPH_PRED', > +'FOR_EACH_ELIM_GRAPH_SUCC', > 'FOR_EACH_EXPR', > 'FOR_EACH_EXPR_1', > +'FOR_EACH_EXPR_ID_IN_SET', > +'FOR_EACH_FLOAT_OPERATOR', > +'FOR_EACH_FP_TYPE', > 'FOR_EACH_FUNCTION', > 'FOREACH_FUNCTION_ARGS', > 'FOREACH_FUNCTION_ARGS_PTR', > 'FOR_EACH_FUNCTION_WITH_GIMPLE_BODY', > +'FOR_EACH_GORI_EXPORT_NAME', > +'FOR_EACH_GORI_IMPORT_NAME', > 'FOR_EACH_HASH_TABLE_ELEMENT', > +'FOR_EACH_HTAB_ELEMENT', > 'FOR_EACH_IMM_USE_FAST', > 'FOR_EACH_IMM_USE_ON_STMT', > +'FOR_EACH_IMM_USE_SAFE', > 'FOR_EACH_IMM_USE_STMT', > 'FOR_EACH_INSN', > 'FOR_EACH_INSN_1', > @@ -103,32 +130,68 @@ ForEachMacros: [ > 'FOR_EACH_INSN_INFO_MW', > 'FOR_EACH_INSN_INFO_USE', > 'FOR_EACH_INSN_USE', > +'FOR_EACH_INT_OPERATOR', > +'FOR_EACH_INT_TYPE', > +'FOR_EACH_INV', > +'FOR_EACH_LOAD_BROADCAST', > +'FOR_EACH_LOAD_BROADCAST_IMM', > 'FOR_EACH_LOCAL_DECL', > +'FOR_EACH_LOG_LINK', > 'FOR_EACH_LOOP', > +'FOR_EACH_LOOP_BREAK', > 'FOR_EACH_LOOP_FN', > +'FOR_EACH_MODE', > +'FOR_EACH_MODE_FROM', > +'FOR_EACH_MODE_IN_CLASS', > +'FOR_EACH_MODE_UNTIL', > +'FOR_EACH_NEST_INFO', > 'FOR_EACH_OBJECT', > 'FOR_EACH_OBJECT_CONFLICT', > +'FOR_EACH_OP', > +'FOR_EACH_PARTITION_PAIR', > +'FOR_EACH_PHI', > 'FOR_EACH_PHI_ARG', > 'FOR_EACH_PHI_OR_STMT_DEF', > 'FOR_EACH_PHI_OR_STMT_USE', > +'FOR_EACH_POP', > 'FOR_EACH_PREF', > +'FOR_EACH_REF', > +'FOR_EACH_REFERENCED_VAR', > +'FOR_EACH_REFERENCED_VAR_IN_BITMAP', > +'FOR_EACH_REFERENCED_VAR_SAFE', > +'FOR_EACH_REF_REV', > +'FOR_EACH_REGNO', > 'FOR_EACH_SCALAR', > +'FOR_EACH_SIGNED_TYPE', > +'FOR_EACH_SSA', > 'FOR_EACH_SSA_DEF_OPERAND', > +'FOR_EACH_SSA_MAYDEF_OPERAND', > +'FOR_EACH_SSA_MUST_AND_MAY_DEF_OPERAND', > +'FOR_EACH_SSA_MUSTDEF_OPERAND', > +'FOR_EACH_SSA_NAME', > 'FOR_EACH_SSA_TREE_OPERAND', > 'FOR_EACH_SSA_USE_OPERAND', > +'FOR_EACH_SSA_VDEF_OPERAND', > 'FOR_EACH_STATIC_INITIALIZER', > +'FOR_EACH_STATIC_VARIABLE', > +'FOR_EACH_STMT_IN_REVERSE', > +'FOR_EACH_SUBINSN', > 'FOR_EACH_SUBRTX', > 'FOR_EACH_SUBRTX_PTR', > 'FOR_EACH_SUBRTX_VAR', > 'FOR_EACH_SUCC', > 'FOR_EACH_SUCC_1', > 'FOR_EACH_SYMBOL', > +'FOR_EACH_TYPE', > +'FOR_EACH_UNSIGNED_TYPE', > +'FOR_EACH_VALUE_ID_IN_SET', > 'FOR_EACH_VARIABLE', > 'FOR_EACH_VEC_ELT', > 'FOR_EACH_VEC_ELT_FROM', > 'FOR_EACH_VEC_ELT_REVERSE', > 'FOR_EACH_VEC_SAFE_ELT', > 'FOR_EACH_VEC_SAFE_ELT_REVERSE', > +'FOR_EACH_WIDER_MODE', > 'FOR_EXPR', > 'FOR_INIT_STMT', > 'FOR_SCOPE' > -- > 2.35.3 >