From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 824E43858D3C for ; Tue, 26 Oct 2021 08:23:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 824E43858D3C Received: by mail-ed1-x536.google.com with SMTP id z20so10735182edc.13 for ; Tue, 26 Oct 2021 01:23:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nADzC8HAS3kVU48ijj1zi8Cg44nbmDlwfKawkEap8NA=; b=YUTYde1f1WJ0F6DL2JGMpey90OZI+m4cSEDCJChA8CxT4XJG4FCBgvaLIVpAKQUPEz Q+IklGwXNAX2OMAiLZUy87EGiZSAFocBFhRptuT/GRbO6nkaX9ruG0ajs/4GdflipGnv iJ3VHnIq4aGSFjOLG40qkb2NcmBJobbJD5ZQ1DQsNFyceLyR0WHuUgoR4L0ixoA54Uzy b19WwiUyUXywRBj8/ZlZlI5SGzekWbd6qqo+W3tUUuXwKodY3XsX9CcEKmiJcYuYNqbf ktylamsp2XDSOap+lFOCKZD3gHxsdU8splG+2CyoWi069/CIsuQbnZExEdDSYTzTk9r7 2oqg== X-Gm-Message-State: AOAM531hiobt6gx64nOWojyO3/3rs6EihJJ6D723Skln0ZgF64jDVxRB p0V8y0ptJl5yX9OQqV3aPi3eM6GPJSRBl+V+l9w= X-Google-Smtp-Source: ABdhPJyWaB7brPO++XfXtoyC43vBPaDbUn9Zl/zP0um1NdSmOlAaBtRDOphzvjsHGmmLbNqYCXTLV03DQCvRZ5CIUdg= X-Received: by 2002:a50:e0c3:: with SMTP id j3mr33645965edl.97.1635236619457; Tue, 26 Oct 2021 01:23:39 -0700 (PDT) MIME-Version: 1.0 References: <72c637b5-f6cc-22d6-af62-65166f5ab069@gmail.com> <923ccb56-fd9c-96ea-6f9d-619668fd789b@gmail.com> In-Reply-To: From: Richard Biener Date: Tue, 26 Oct 2021 10:23:28 +0200 Message-ID: Subject: Re: [PATCH v3] detect out-of-bounds stores by atomic functions [PR102453] To: Jeff Law Cc: Martin Sebor , gcc-patches , Jan Hubicka Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Oct 2021 08:23:42 -0000 On Mon, Oct 25, 2021 at 4:21 AM Jeff Law wrote: > > > > On 10/24/2021 5:40 PM, Martin Sebor via Gcc-patches wrote: > > Attached is a revised patch for just the access warning pass > > to diagnose out-of-bounds stores by atomic functions, with > > no attr-fnspec changes. > > > > Is this okay for trunk? > > > > Martin > > > > PS Just to clarify the effect of the original patch in case > > it wasn't: it didn't enable optimizations of atomic built-ins. > > It just made it possible, by first calling the new > > atomic_builtin_fnspec() to get the fnspec, and then by actually > > doing something with it. The original patch did not modify > > builtin_fnspec() to call the new atomic_builtin_fnspec(). But > > since you seem to have reservations about exposing the attribute > > in any form I have withdrawn the original patch and replaced it > > with the more limited one. > > > > > I'm letting Richi take the lead here. But I did notice a tiny nit: > > > > + > > + /* Tyhe size in bytes of the access by the function, and the number > s/Tyhe/The/ The patch looks OK to me. Thanks, Richard. > >