From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com
 [IPv6:2a00:1450:4864:20::635])
 by sourceware.org (Postfix) with ESMTPS id 8F9D03891C16
 for <gcc-patches@gcc.gnu.org>; Fri, 16 Apr 2021 06:38:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8F9D03891C16
Received: by mail-ej1-x635.google.com with SMTP id l4so40458461ejc.10
 for <gcc-patches@gcc.gnu.org>; Thu, 15 Apr 2021 23:38:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=hHwn86YYqNKBZUp2+PguWoIFqIkuT2Pw0qaQdG/J6t4=;
 b=my2LpiKAF5D3lhOzVhfU2d+8GLqXVBmEoEbJ3arzm/VwRlQDbwuEi2J7S38rwftdzR
 /wcI8FimEpNIXdhH5EJlzf2PJMQC/xUk3+kdST8VUCrFJPu70d/s+onnAxZSIGpMzz9f
 xWjjPPZKFcxSJxP7BUKQpx3dKe+Ix0428jDnza++sVB7iAeEeP0Wm2ZGeoFr9gqzBx2O
 K7CkME7zVxtkwrAvl7PX5tOlqkEN6MPQeSXamDi/u33GMr/j/Fp9vZHecQkX0rhQVVMF
 iiYG2oSXTAHGlsJLyakdi7TiVcdU48g92PgFCMj3Me8n+L7YBJo3Xb7KAluNnnVKfe4s
 Z/7Q==
X-Gm-Message-State: AOAM533m3rxofgzGTrXHzxMOEucC3x76rc4XsIGMVWVkmlYIfsCp1PwT
 oMFnqU4Ekumcf2Mmy0nMjzige2ekfBKPEbjbgBwmV9XYSBk=
X-Google-Smtp-Source: ABdhPJziUzD/UcoeLQUWpOnTApRB9vo4FK+nt/xtfib0TtJ+/3XPPikPRmLSq4GBm/zX2/VVGKcJw9ToqY0BpdjovFk=
X-Received: by 2002:a17:906:29ca:: with SMTP id
 y10mr7110092eje.250.1618555138418; 
 Thu, 15 Apr 2021 23:38:58 -0700 (PDT)
MIME-Version: 1.0
References: <495cec56-f914-d114-3882-fa9642d9ffce@linux.ibm.com>
In-Reply-To: <495cec56-f914-d114-3882-fa9642d9ffce@linux.ibm.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Fri, 16 Apr 2021 08:38:47 +0200
Message-ID: <CAFiYyc2emSU29JjKYgp6tJs1+jrycNEZXyeqVsqtYMjQ2nFbZQ@mail.gmail.com>
Subject: Re: [PATCH] testsuite: Move gimplefe40.c and gimplefe41.c
To: Robin Dapp <rdapp@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Apr 2021 06:39:00 -0000

On Thu, Apr 15, 2021 at 6:50 PM Robin Dapp via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
>
> the gimplefe40 and gimplefe41.c tests expect vector capabilities
> (vect_float etc.) yet are not in the vect subdirectory.  This causes
> both to be called unconditionally without prior target-specific vector
> setup normally performed by vect/vect.exp.
>
> There is a target-specific option for powerpc
>
>   /* { dg-additional-options "-maltivec" { target { powerpc*-*-* &&
> powerpc_altivec_ok } } } */
>
> which enables Altivec on supported targets but I'd rather not create
> another special case for s390.  I suppose the better solution is to move
> these tests to the vect subdirectory.
>
> Is this OK?

Do the testcases currently fail?  How?  In principle moving to vect/
is OK but then having the gimplefe testcases in one place is nice ...

Richard.

> Regards
>   Robin
>
> --
>
> gcc/testsuite/ChangeLog:
>
>          * gcc.dg/gimplefe-40.c: Moved to...
>          * gcc.dg/vect/gimplefe-40.c: ...here.
>          * gcc.dg/gimplefe-41.c: Moved to...
>          * gcc.dg/vect/gimplefe-41.c: ...here.