Re: [patch] Adjust gcc-plugin.h

[Richard Biener <richard.guenther@gmail.com>]

On Tue, Jun 9, 2015 at 2:32 PM, Andrew MacLeod <amacleod@redhat.com> wrote:
> On 06/09/2015 03:56 AM, Richard Biener wrote:
>>
>> On Mon, Jun 8, 2015 at 7:52 PM, Andrew MacLeod <amacleod@redhat.com>
>> wrote:
>>>
>>>
>>> the gcc source files need to see the internal bits in plugin.h, as well
>>> as
>>> the common decls in gcc-plugin.h.  So we could change the includes as you
>>> suggest, but we'd have to copy all the decls from gcc-inlcude.h to
>>> plugin.h
>>> so the gcc functions can see them.  And then the plugins would be exposed
>>> to
>>> all the internal APIs and decls present in plugins.h
>>
>> plugins are exposed to all internals of GCC anyway.  gcc-plugin.h should
>> really
>> just be a #include kitchen-sink.
>>
>>
>>>   Im presuming
>>> we didnt want to do that and thats why there were 2 files to start with.
>>
>> No, gcc-plugin.h was introduced to make the set of includes required
>> for plugins "stable".
>>
>> Richard.
>>
>>
> I didn't actually realize that.. at least its serving its true purpose now
> :-)
>
> So hows this.  Bootstrapping and testruns proceeding now, but it should have
> the same results as the other patch.
> Assuming no regressions, OK?

Ok.

Richard.

> Andrew
>
>
>