From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37056 invoked by alias); 9 Jun 2015 12:34:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 37038 invoked by uid 89); 9 Jun 2015 12:34:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f169.google.com Received: from mail-ob0-f169.google.com (HELO mail-ob0-f169.google.com) (209.85.214.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 09 Jun 2015 12:34:57 +0000 Received: by obbgp2 with SMTP id gp2so11531748obb.2 for ; Tue, 09 Jun 2015 05:34:55 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.79.196 with SMTP id d187mr17921980oib.46.1433853295315; Tue, 09 Jun 2015 05:34:55 -0700 (PDT) Received: by 10.76.115.167 with HTTP; Tue, 9 Jun 2015 05:34:55 -0700 (PDT) In-Reply-To: <5576DCD7.3040309@redhat.com> References: <55758574.7070104@redhat.com> <5575D64A.1020102@redhat.com> <5576DCD7.3040309@redhat.com> Date: Tue, 09 Jun 2015 12:57:00 -0000 Message-ID: Subject: Re: [patch] Adjust gcc-plugin.h From: Richard Biener To: Andrew MacLeod Cc: gcc-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00661.txt.bz2 On Tue, Jun 9, 2015 at 2:32 PM, Andrew MacLeod wrote: > On 06/09/2015 03:56 AM, Richard Biener wrote: >> >> On Mon, Jun 8, 2015 at 7:52 PM, Andrew MacLeod >> wrote: >>> >>> >>> the gcc source files need to see the internal bits in plugin.h, as well >>> as >>> the common decls in gcc-plugin.h. So we could change the includes as you >>> suggest, but we'd have to copy all the decls from gcc-inlcude.h to >>> plugin.h >>> so the gcc functions can see them. And then the plugins would be exposed >>> to >>> all the internal APIs and decls present in plugins.h >> >> plugins are exposed to all internals of GCC anyway. gcc-plugin.h should >> really >> just be a #include kitchen-sink. >> >> >>> Im presuming >>> we didnt want to do that and thats why there were 2 files to start with. >> >> No, gcc-plugin.h was introduced to make the set of includes required >> for plugins "stable". >> >> Richard. >> >> > I didn't actually realize that.. at least its serving its true purpose now > :-) > > So hows this. Bootstrapping and testruns proceeding now, but it should have > the same results as the other patch. > Assuming no regressions, OK? Ok. Richard. > Andrew > > >