From: Richard Biener <richard.guenther@gmail.com>
To: Yuri Rumyantsev <ysrumyan@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Igor Zamyatin <izamyatin@gmail.com>,
Kirill Yukhin <kirill.Yukhin@gmail.com>
Subject: Re: [PATCH PR68542]
Date: Mon, 18 Jan 2016 14:07:00 -0000 [thread overview]
Message-ID: <CAFiYyc2g7jPKYeTd=8DTjDdsf7ND1jdjn4ZwH2u1MeNzPHea0Q@mail.gmail.com> (raw)
In-Reply-To: <CAEoMCqRhaFMKeKch58PPZ0EgGW_7PGm7WsUVBYnTqnfAfQ7_Pw@mail.gmail.com>
On Mon, Jan 18, 2016 at 3:02 PM, Yuri Rumyantsev <ysrumyan@gmail.com> wrote:
> Thanks Richard.
>
> I changed the check on type as you proposed.
>
> What about the second back-end part of patch (it has been sent 08.12.15).
Can't see it in my inbox - can you reply to the mail with a ping?
Thanks,
Richard.
> Thanks.
> Yuri.
>
> 2016-01-18 15:44 GMT+03:00 Richard Biener <richard.guenther@gmail.com>:
>> On Mon, Jan 11, 2016 at 11:06 AM, Yuri Rumyantsev <ysrumyan@gmail.com> wrote:
>>> Hi Richard,
>>>
>>> Did you have anu chance to look at updated patch?
>>
>> diff --git a/gcc/tree-vrp.c b/gcc/tree-vrp.c
>> index acbb70b..208a752 100644
>> --- a/gcc/tree-vrp.c
>> +++ b/gcc/tree-vrp.c
>> @@ -5771,6 +5771,10 @@ register_edge_assert_for (tree name, edge e,
>> gimple_stmt_iterator si,
>> &comp_code, &val))
>> return;
>>
>> + /* VRP doesn't track ranges for vector types. */
>> + if (TREE_CODE (TREE_TYPE (name)) == VECTOR_TYPE)
>> + return;
>> +
>>
>> please instead fix extract_code_and_val_from_cond_with_ops with
>>
>> Index: gcc/tree-vrp.c
>> ===================================================================
>> --- gcc/tree-vrp.c (revision 232506)
>> +++ gcc/tree-vrp.c (working copy)
>> @@ -5067,8 +5067,9 @@ extract_code_and_val_from_cond_with_ops
>> if (invert)
>> comp_code = invert_tree_comparison (comp_code, 0);
>>
>> - /* VRP does not handle float types. */
>> - if (SCALAR_FLOAT_TYPE_P (TREE_TYPE (val)))
>> + /* VRP only handles integral and pointer types. */
>> + if (! INTEGRAL_TYPE_P (TREE_TYPE (val))
>> + && ! POINTER_TYPE_P (TREE_TYPE (val)))
>> return false;
>>
>> /* Do not register always-false predicates.
>>
>> Ok with that change.
>>
>> Thanks,
>> Richard.
>>
>>> Thanks.
>>> Yuri.
>>>
>>> 2015-12-18 13:20 GMT+03:00 Yuri Rumyantsev <ysrumyan@gmail.com>:
>>>> Hi Richard,
>>>>
>>>> Here is updated patch for middle-end part of the whole patch which
>>>> fixes all your remarks I hope.
>>>>
>>>> Regression testing and bootstrapping did not show any new failures.
>>>> Is it OK for trunk?
>>>>
>>>> Yuri.
>>>>
>>>> ChangeLog:
>>>> 2015-12-18 Yuri Rumyantsev <ysrumyan@gmail.com>
>>>>
>>>> PR middle-end/68542
>>>> * fold-const.c (fold_binary_op_with_conditional_arg): Bail out for case
>>>> of mixind vector and scalar types.
>>>> (fold_relational_const): Add handling of vector
>>>> comparison with boolean result.
>>>> * tree-cfg.c (verify_gimple_comparison): Add argument CODE, allow
>>>> comparison of vector operands with boolean result for EQ/NE only.
>>>> (verify_gimple_assign_binary): Adjust call for verify_gimple_comparison.
>>>> (verify_gimple_cond): Likewise.
>>>> * tree-ssa-forwprop.c (combine_cond_expr_cond): Do not perform
next prev parent reply other threads:[~2016-01-18 14:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 13:24 Yuri Rumyantsev
2015-12-04 12:18 ` Richard Biener
2015-12-04 15:07 ` Yuri Rumyantsev
2015-12-07 10:57 ` Yuri Rumyantsev
2015-12-08 12:34 ` Yuri Rumyantsev
2015-12-10 13:36 ` Richard Biener
2015-12-11 14:03 ` Yuri Rumyantsev
2015-12-16 13:37 ` Richard Biener
2015-12-18 10:20 ` Yuri Rumyantsev
2016-01-11 10:06 ` Yuri Rumyantsev
2016-01-18 12:44 ` Richard Biener
2016-01-18 14:02 ` Yuri Rumyantsev
2016-01-18 14:07 ` Richard Biener [this message]
2016-01-18 14:50 ` Yuri Rumyantsev
2016-01-20 12:25 ` Richard Biener
2016-01-22 14:29 ` Yuri Rumyantsev
2016-01-22 14:50 ` H.J. Lu
2016-01-28 13:26 ` Richard Biener
2016-01-28 13:37 ` Yuri Rumyantsev
2016-01-28 14:24 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc2g7jPKYeTd=8DTjDdsf7ND1jdjn4ZwH2u1MeNzPHea0Q@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=izamyatin@gmail.com \
--cc=kirill.Yukhin@gmail.com \
--cc=ysrumyan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).