From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id DFDAF3858C78; Sat, 5 Nov 2022 11:13:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFDAF3858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x631.google.com with SMTP id y14so19184397ejd.9; Sat, 05 Nov 2022 04:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=n0/0cwRTocZ4F9G/O7b3U0YjiJp1HrR6bR2dqHexQLg=; b=S5FzD1PaIIIk5ZVEVmV0WVbRbz1dRgWodb+dJT+56NXYdBtunDa0gQ4eTkxEDMSHU6 IfHMnZOQbIjOXk6xNCpfYWK+p/pb/A8Ip7rOpjkwlInNPduGDHpeJB06nLB0Y5wLxBIi FSpCxB08/o8aVUNrLm9qfCiEtwAh+5D9aMStYwRpvFu9+4i/58caPvnWYdmGIjCq5+cP Ol6GoM8jVgj3kjuH+ptJtXRSHcLsskjYnh+npRPlPn6THB+cFp72UP++0n01+E586SFU rg0PuKN2qgGNJOv9sL3sIdYBNw2SlbEL1b9kv3wR/+nqbhrI8e5aIBRU6kizOsPx3sDu fMVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n0/0cwRTocZ4F9G/O7b3U0YjiJp1HrR6bR2dqHexQLg=; b=t7Gwc0x8NG0ZiS4+H8rzgd2QkRzTElj47Q/LTTC/XeYACePH2yB9h5yY/xxElBKNKJ q/6IE+OmeQxIbog2QgeYIyPpfuXn/b6Gh/DObjCwj6nBFt+5Cluu/3fffwuK+COMc1Rq EtiLXhbRv9duzyFopV+yQw3dD/xZokq7fgttyJJTAW4obOnhcbO1mUHuJzoVvtcjWY4Q OckVIEZfBP7Boz3EI7PJq+RGx/J0mH6b4RCsCWzIm2tNeoZJL4RPvcnR9AT8XweCkH1S HHGhS3A8AQlmxpAExK8w19zRGDxBu+sIDbiZpKzt4cDa2rsZCed1Yw2v1JwQ+XmbG4yt Ll0A== X-Gm-Message-State: ACrzQf1v2+l2cKqRowH4kDmm288rBvcgks+A3upbMACTou6J6DO8f/v3 tAVqJy3YUlvuJKFJFAr/rW/CB5rbN+vApZYyeCg= X-Google-Smtp-Source: AMsMyM7LAJjFE96sF3Qp5+kZNCtaQ3KW6wRyItn9Nd0mS7Xa/C06GQP0LhWrtYkL2hTY+mpf6hQo0wL1lRCghU+fWsU= X-Received: by 2002:a17:907:2c68:b0:7ad:8ba7:664a with SMTP id ib8-20020a1709072c6800b007ad8ba7664amr38852164ejc.488.1667646806631; Sat, 05 Nov 2022 04:13:26 -0700 (PDT) MIME-Version: 1.0 References: <20221103210049.516886-1-aldot@gcc.gnu.org> In-Reply-To: <20221103210049.516886-1-aldot@gcc.gnu.org> From: Richard Biener Date: Sat, 5 Nov 2022 12:13:14 +0100 Message-ID: Subject: Re: [PATCH] Plug memory leak in attribute target_clones To: Bernhard Reutner-Fischer Cc: gcc-patches@gcc.gnu.org, Bernhard Reutner-Fischer Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 3, 2022 at 10:01 PM Bernhard Reutner-Fischer via Gcc-patches wrote: > > It looks like there was some memory leak in the handling > of attribute target_clones, introduced in 5928bc2ec06d . > > Ok for trunk if testing passes? OK > gcc/ChangeLog: > > * multiple_target.cc (expand_target_clones): Free memory. > > Signed-off-by: Bernhard Reutner-Fischer > --- > gcc/multiple_target.cc | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/gcc/multiple_target.cc b/gcc/multiple_target.cc > index 67866a7c963..77e0f21dd05 100644 > --- a/gcc/multiple_target.cc > +++ b/gcc/multiple_target.cc > @@ -390,19 +390,23 @@ expand_target_clones (struct cgraph_node *node, bool definition) > for (i = 0; i < attrnum; i++) > { > char *attr = attrs[i]; > - char *suffix = XNEWVEC (char, strlen (attr) + 1); > > - create_new_asm_name (attr, suffix); > /* Create new target clone. */ > tree attributes = make_attribute ("target", attr, > DECL_ATTRIBUTES (node->decl)); > > + char *suffix = XNEWVEC (char, strlen (attr) + 1); > + create_new_asm_name (attr, suffix); > cgraph_node *new_node = create_target_clone (node, definition, suffix, > attributes); > + XDELETEVEC (suffix); > if (new_node == NULL) > - return false; > + { > + XDELETEVEC (attrs); > + XDELETEVEC (attr_str); > + return false; > + } > new_node->local = false; > - XDELETEVEC (suffix); > > decl2_v = new_node->function_version (); > if (decl2_v != NULL) > -- > 2.38.1 >