From: Richard Biener <richard.guenther@gmail.com>
To: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org,
Segher Boessenkool <segher@kernel.crashing.org>,
"Kewen.Lin" <linkw@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>,
Will Schmidt <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH 0/2] Repost of patches for solving the build on Fedora 36 problem
Date: Fri, 3 Feb 2023 08:42:41 +0100 [thread overview]
Message-ID: <CAFiYyc2j6Ocq5uixQgybDvsOuPh1aKwOHNK6UezS_X6SraALDg@mail.gmail.com> (raw)
In-Reply-To: <Y9yfDC9bMaaB86ZP@toto.the-meissners.org>
On Fri, Feb 3, 2023 at 6:44 AM Michael Meissner via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> I'm reposting these two patches that allow GCC to build on Fedora 36 just to be
> clear which patches I'm talking about. The issue is that if GCC is configured
> with long double using the IEEE 128-bit representation, it currently cannot
> build _mulkc3 and _divkc3 in libgcc.
It's interesting that we do not see this with openSUSE where I configure with
--with-cpu=power8 --with-tune=power9 --with-long-double-format=ieee
--with-long-double-128
note this is ppc64le, we leave ppc64 and ppc with their default.
> Note, these patches do not solve the underlying problem of mixing _Float128 and
> long double types and using built-in functions (i.e. calling a _Float128
> built-in function with long double arguments when long double is IEEE 128-bit,
> or vice versa calling a long double built-in function with _Float128
> arguments). But they do allow the compiler to build.
>
> Note, it is the morning of February 3rd, and I will be off on vacation from
> February 7th through February 14th.
>
> The first patch changes libgcc so that it uses either _Float128 or long double
> as the base IEEE 128-bit type, depending on whether long double uses the IBM
> double-double representation, or the IEEE 128-bit representation. And for the
> complex type it uses _Complex _Float128 or _Complex long double. The _mulkc3
> and _divkc3 functions are adjusted to use the f128 built-in functions or the
> long double built-in functions, based on the long double type.
>
> The second patch improves how the compiler generates the call to _mulkc3 and
> _divkc3. I've discovered as I have tried to fix underlying problem with the
> IEEE 128-bit floating point types, it breaks the calls for IEEE 128-bit complex
> multiply and divide. This patch uses a cleaner approach to generate these
> calls, and it will work with the current setup, and with the various fixes that
> I've attempted to do to fix the underlying problem.
>
> --
> Michael Meissner, IBM
> PO Box 98, Ayer, Massachusetts, USA, 01432
> email: meissner@linux.ibm.com
next prev parent reply other threads:[~2023-02-03 7:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 5:43 Michael Meissner
2023-02-03 5:49 ` [PATCH 1/2] PR target/107299: Fix build issue when long double is IEEE 128-bit Michael Meissner
2023-02-22 10:37 ` Kewen.Lin
2023-02-22 18:11 ` Michael Meissner
2023-03-02 22:45 ` Ping: " Michael Meissner
2023-03-03 20:56 ` Segher Boessenkool
2023-02-03 5:53 ` [PATCH 2/2] Rework 128-bit complex multiply and divide Michael Meissner
2023-02-22 10:13 ` Kewen.Lin
2023-02-22 18:01 ` Michael Meissner
2023-03-02 22:46 ` Ping: " Michael Meissner
2023-03-03 21:35 ` Segher Boessenkool
2023-03-09 16:11 ` Michael Meissner
2023-03-09 22:16 ` Segher Boessenkool
2023-03-09 23:23 ` Michael Meissner
2023-03-09 16:42 ` Michael Meissner
2023-02-03 7:42 ` Richard Biener [this message]
2023-02-06 18:28 ` [PATCH 0/2] Repost of patches for solving the build on Fedora 36 problem Peter Bergner
2023-02-07 14:22 ` Richard Biener
2023-02-07 14:31 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc2j6Ocq5uixQgybDvsOuPh1aKwOHNK6UezS_X6SraALDg@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=meissner@linux.ibm.com \
--cc=segher@kernel.crashing.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).