From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 88D723858C56 for ; Fri, 14 Oct 2022 06:12:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 88D723858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62d.google.com with SMTP id q9so8447607ejd.0 for ; Thu, 13 Oct 2022 23:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=f3K/DImRWOnYu7r2h/3H2jfjydWbgd/9+d+2L4EVLxE=; b=IreQMXftMDylTo/7nPeOukdZxJy1fT4sncVJXDXDx1eDk1edIrJBtYaAhqQQvGtApw EGAkTo/+L7v8BcsSaynRXF7dJcuUIsmCnYmliWEJX7fgMNBeQYBljq6uIoiuLcE1Htyv 8iYZ/scNReeJkdRTqsceY5+edPVs6cePJlrQeO5tpn2q3zdy1gRrpu2QWmQFKYcrsIDO 5wL3z0o8X8hZehCst84nKCG0eH/T7lYdvYvkN0wfzErFLTJi9PvHTFnzVelsB+1p9uFX GpQveOSpZ+CdltsGRuVLWy3Z8McRt54y8nAUtasJR9voHqyJs5WYGlKNKxtMvRCqXAhR /lpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f3K/DImRWOnYu7r2h/3H2jfjydWbgd/9+d+2L4EVLxE=; b=HmS+gDrmb5ra5Ny0erxKvYKLC0hc01GqO9xc6jOhOpN8mxYGh3tVL7Sk1Q3EtP6Ln+ OzeFMjRSujwxTybQ5p5VrL9GdFoX3QuN1WSXwZYytbtGS/xTs3yxzAE3GGd/AVoyIoFA nWT9lJPIZR6rB7ZxtBEpPF+2nOx8WZBy7O6w1P3G7IU+ijN2khV63azsTJP5+pRlcJPx AZ/w9/6MHwaQZ36sNwmIjWFjbrC1KRmNMjuaMJfh+pakCMwoxInkmo8eaw8RYR8dJNYh gXVxq5S97Wihdhk38Girz2iosE03GabU+HgawbRr5fF4YTz1El90fzNacGD/pgTVfVup KKig== X-Gm-Message-State: ACrzQf3hJw9FplSXSB63hgUg32s60Z60VSrF5hK4Fkgzvv8ZrpIibslS AcDSIc2riw/qYfrGZimUvsDPHvTOC/9l6qPthg8= X-Google-Smtp-Source: AMsMyM7YabAynx7blZAOkhQbhMwOUDmRqFyyAar4qmYVDjNb11PdTHvL4h/0JLK7YqGBnQ/ZI72kAJZc/fO3ilN1n5Y= X-Received: by 2002:a17:907:8a27:b0:78e:274e:9235 with SMTP id sc39-20020a1709078a2700b0078e274e9235mr605542ejc.754.1665727936096; Thu, 13 Oct 2022 23:12:16 -0700 (PDT) MIME-Version: 1.0 References: <3194055.aeNJFYEL58@fomalhaut> <1908968.PYKUYFuaPT@fomalhaut> In-Reply-To: <1908968.PYKUYFuaPT@fomalhaut> From: Richard Biener Date: Fri, 14 Oct 2022 08:12:03 +0200 Message-ID: Subject: Re: [PATCH] Fix bogus -Wstringop-overflow warning To: Eric Botcazou , =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: Jeff Law , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Oct 14, 2022 at 12:54 AM Eric Botcazou via Gcc-patches wrote: > > > Not a fan as it could potentially hide a real issue, but I don't really > > have a better solution. > > Thanks. > > > I pondered suggesting "access" affect type identity, but the cases where > > that's really important are probably better handled by the "fn spec" > > attribute, leaving "access" strictly impacting diagnostics. > > I can expand a bit here, because I tried to change the "access" attribute that > way and this badly breaks the C compiler, for example: > > int foo (int n, char m[1][n]); > > int foo (int n, char m[1][n]) {} > > no longer compiles with an error about different function types. Note in discussion with IPA folks we agreed that IPA cloning that modifies arguments either has to remove access attributes, adjust them or refrain from cloning. Martin - has anything been done to this respect? I suppose there's also a way to figure if a clone has arguments changed in any way? Thanks, Richard. > -- > Eric Botcazou > >