From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id E8CF63858D1E for ; Mon, 17 Jul 2023 06:19:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E8CF63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2b6f97c7115so58807381fa.2 for ; Sun, 16 Jul 2023 23:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689574796; x=1692166796; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jEyyFFn3BWXOObreN6DtBOhtebVy3YUkyfWbaZZehcM=; b=akCYh6nqdhg6ztjzfgQzZrfCJQKnCsfVjlizQPdrnv9DtnAInL6aJ4s8CImipx9R+y IpcZGynmor4+4yeNVntjSeLttcCdEcms8TB6zxdFI5umCepgb+dBcfDhlRDUj4qrf1+G SXWASeIcBaqL9qIhgNnx0UCN3L0yKPdvQH0Efb8/67LuHcbdMd8/Jl9E4xWteUo9eQp9 n99GkzaBP+kM7jeDyxZx17D32HFscRbym9rwdIWXShlzZZdrNKS+JRVlUjUWpzbSEY43 xZYytiF7QzEXoFrQ3Y8pURvSXkN7gLd8+JE6Aji4gcXa3h36GlPcS4bH+0ysjwBigVpN TTrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689574796; x=1692166796; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jEyyFFn3BWXOObreN6DtBOhtebVy3YUkyfWbaZZehcM=; b=EUrqMMuESCdRD5R64Q6kLKYfw34asSQIdbIFnjrgCmwnzriLZpFr8HTl48QDCAeOCA N4IIETmt0nW5/to2Z5vDD9DcCY+ytq44eegb5PqB7JIqJsGY1LxBpli/eMZm3FMZ83iV /kLHoT0X4lSnIhbk81RodJOmv6dJGsE8iMDhhuuAnGhfY8ZoFJo3PJ0SxScjnyIJc1wd gPIepj4LVOLZv2qUfIABQsy4rpU4KBx/NMidhme7HZwCRtAWJJJORp+JCrHwapB/1S6+ +BzyjdnNH4FY1VY6tSE99/bGycanpK4CN/Xmum7CawTdSVmfX7kIDJsSkUwMKJrczqJq 8JZw== X-Gm-Message-State: ABy/qLYXyHH2+az88DtASaUS5xWDj8DDUvyP9Fzprc99oc5eYnuGeE25 DI3pqCgE/t4TYTZNpMA3ubA9E0sL7z34jiyiqtp0D/s+ X-Google-Smtp-Source: APBJJlEsLXrtq6ERP8L9Zl20th/iSdBEEsOKv6NYH274mS8ZW7esoLIrXEIotfhiptqsWqu6TO1U5ndTJJF+AVP4JSU= X-Received: by 2002:a2e:7404:0:b0:2b6:ef5d:965c with SMTP id p4-20020a2e7404000000b002b6ef5d965cmr6918236ljc.44.1689574796004; Sun, 16 Jul 2023 23:19:56 -0700 (PDT) MIME-Version: 1.0 References: <001201d9b684$e319fdd0$a94df970$@nextmovesoftware.com> In-Reply-To: <001201d9b684$e319fdd0$a94df970$@nextmovesoftware.com> From: Richard Biener Date: Mon, 17 Jul 2023 08:19:25 +0200 Message-ID: Subject: Re: [PATCH] Fix bootstrap failure (with g++ 4.8.5) in tree-if-conv.cc. To: Roger Sayle Cc: gcc-patches@gcc.gnu.org, Tamar Christina Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jul 14, 2023 at 8:56=E2=80=AFPM Roger Sayle wrote: > > > > This patch fixes the bootstrap failure I'm seeing using gcc 4.8.5 as > > the host compiler. Ok for mainline? [I might be missing something] OK. Btw, while I didn't spot this during review I would appreciate if the code could use vec.[q]sort, this should work with a lambda as well I think. > > > > > 2023-07-14 Roger Sayle > > > > gcc/ChangeLog > > * tree-if-conv.cc (predicate_scalar_phi): Make the arguments > > to the std::sort comparison lambda function const. > > > > > > Cheers, > > Roger > > -- > > >