public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Make -flto=jobserver parallel again.
@ 2019-08-23 11:24 Martin Liška
  2019-08-23 11:40 ` Richard Biener
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Liška @ 2019-08-23 11:24 UTC (permalink / raw)
  To: gcc-patches; +Cc: Richard Biener

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

Hi.

As I did quite some changes in the LTO logic, revision
r274232 dropped default value of parallel back to 0.
Doing that, I forgot to set it to 1 at the places where
jobserver is detected.

I tested that LTO bootstrap is parallel again.

Ready to be installed?
Thanks,
Martin

gcc/ChangeLog:

2019-08-23  Martin Liska  <mliska@suse.cz>

	* lto-wrapper.c (run_gcc): When setting jobserver
	set also parallel to 1.  This was done so before r273908.
---
 gcc/lto-wrapper.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)



[-- Attachment #2: 0001-Make-flto-jobserver-parallel-again.patch --]
[-- Type: text/x-patch, Size: 743 bytes --]

diff --git a/gcc/lto-wrapper.c b/gcc/lto-wrapper.c
index 68f63da910f..75ed289f3f2 100644
--- a/gcc/lto-wrapper.c
+++ b/gcc/lto-wrapper.c
@@ -1374,7 +1374,10 @@ run_gcc (unsigned argc, char *argv[])
 
 	case OPT_flto_:
 	  if (strcmp (option->arg, "jobserver") == 0)
-	    jobserver = 1;
+	    {
+	      parallel = 1;
+	      jobserver = 1;
+	    }
 	  else if (strcmp (option->arg, "auto") == 0)
 	    {
 	      parallel = 1;
@@ -1423,8 +1426,11 @@ run_gcc (unsigned argc, char *argv[])
       auto_parallel = 0;
       parallel = 0;
     }
-  else if (!jobserver)
-    jobserver = jobserver_active_p ();
+  else if (!jobserver && jobserver_active_p ())
+    {
+      parallel = 1;
+      jobserver = 1;
+    }
 
   if (linker_output)
     {


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Make -flto=jobserver parallel again.
  2019-08-23 11:24 [PATCH] Make -flto=jobserver parallel again Martin Liška
@ 2019-08-23 11:40 ` Richard Biener
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2019-08-23 11:40 UTC (permalink / raw)
  To: Martin Liška; +Cc: GCC Patches

On Fri, Aug 23, 2019 at 1:02 PM Martin Liška <mliska@suse.cz> wrote:
>
> Hi.
>
> As I did quite some changes in the LTO logic, revision
> r274232 dropped default value of parallel back to 0.
> Doing that, I forgot to set it to 1 at the places where
> jobserver is detected.
>
> I tested that LTO bootstrap is parallel again.
>
> Ready to be installed?

OK.

Richard.

> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> 2019-08-23  Martin Liska  <mliska@suse.cz>
>
>         * lto-wrapper.c (run_gcc): When setting jobserver
>         set also parallel to 1.  This was done so before r273908.
> ---
>  gcc/lto-wrapper.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-23 11:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-23 11:24 [PATCH] Make -flto=jobserver parallel again Martin Liška
2019-08-23 11:40 ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).