From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 4ABD0396E854 for ; Thu, 7 Jan 2021 08:42:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4ABD0396E854 Received: by mail-ed1-x529.google.com with SMTP id r5so6909277eda.12 for ; Thu, 07 Jan 2021 00:42:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+su+JaxHwERa4BlCu6COHPynkJSMvUi1GoG1Jk26Wtw=; b=DnEtw/lrCLVvD3zpAK0c06ISnwzVNffavlR3ybbE8wQh0Y0w9gzKl7D1Uu4DJkfEQX ZMPeG49A8ymX4vJ8KVapD+dHXeaFWGBh464uzWlUPzWAphr288M3zCKe9B9NwlE+SOeH ox3L+bQzzScsvTGSAqc5IcOw1kHqG3cVKSTDxiaPQkqecCY9Hg6Dd+hmOpNXTA5ZxW1A AqH+Nfjd85AuuhD/cVz++dzweqlDYr/FiK0AlVtVMYBgYeDxErZvdoPasD3cLsm1IRz1 jqlDSbLc9+uz1EqkY2HCzkgq7brmchWyWfgurhrn0NJfJ4up5poqu+OO/0+I3qJsgxyh 1roQ== X-Gm-Message-State: AOAM5319t01zte5lPCWHVrfeofXJj1pe/OERugLtDNsaJsst6WXoeaTv A7jYKE90d15tB33Ix7AMRe2aofuU4qJAtkM+qKM= X-Google-Smtp-Source: ABdhPJz00F9A4IKViawHfpDmx//vNSYR//MZRZfJlFlYId9pDNNesEec/ysvQZnJ4j+qWrh3x1qVhqx2L+76KipmnJE= X-Received: by 2002:aa7:cf85:: with SMTP id z5mr892026edx.274.1610008930427; Thu, 07 Jan 2021 00:42:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Thu, 7 Jan 2021 09:41:59 +0100 Message-ID: Subject: Re: make FOR_EACH_IMM_USE_STMT safe for early exits To: Alexandre Oliva Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2021 08:42:14 -0000 On Wed, Jan 6, 2021 at 12:34 PM Alexandre Oliva wrote: > > On Jan 4, 2021, Richard Biener wrote: > > > Hmm - while the change looks good, doesn't it end up > > calling end_imm_use_stmt_tranverse twice for those > > uses still calling BREAK_FROM_IMM_USE_STMT? > > It does. I'd considered introducing a separate method to call > end_imm_use_stmt_traverse if imm is not NULL, and then set it to NULL, > but calling the function multiple times is not a problem: delink_imm_use > just returns immediately the second time. > > > Thus, please remove uses of BREAK_FROM_IMM_USE_STMT > > together with this patch. > > And RETURN_FROM_IMM_USE_STMT, I suppose? Sure. > I wasn't sure whether to remove them and their users. > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Vim, Vi, Voltei pro Emacs -- GNUlius Caesar