From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 2A70F3858D3C for ; Fri, 19 Nov 2021 09:38:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A70F3858D3C Received: by mail-ed1-x52d.google.com with SMTP id r25so3282572edq.7 for ; Fri, 19 Nov 2021 01:38:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=p3qNxeGkNrLyF65YER0Vl11ZjHYES1sZDi5fyCiZo0Q=; b=TiYBzZp2vDHdon58dCUDKC2B+brgQvgBFllWL79iJTKheXuQS3qLlqbIpd5XCuvJDk gMbqBWAt7f0+qWUD0fiJz/myGd7UP+V7oPXJw3Lnt0NB4Su5mEeOf6TM+aGsBbjAxAVP trSfOGhf5ZajgI9znLpCwktFq8gi/7WaTh2DIvvT3Td6eSwTOYOZ+fnuuxrrgnYARfsy t6WP242PR2ARwEcLF6syejsnA7VLIoJWwbNlFmkvWGUp4uf1F2nY9CfJcSXtk9E/h8an vTyDCcnils+pVlTj/hTEoR/u23peP7d3iujEK4m0ItGSn5lnRaomGgyPA3krEuGIhjjK GEqA== X-Gm-Message-State: AOAM533uxRq/enii15tIhX9u/gDqbZEyBKPSl/9FByMxbQTOFwzvizL+ ia77P/0xVyecNYHMwxJzexD2c/D1KTRkYysp4JY= X-Google-Smtp-Source: ABdhPJysmXPPmeAy9ikJjuuX17QgLHLkRnr2T8ERecwzut7MRWltVq118M+Ka0l8Pc58Be6nRH7doC3S1iRnbMAaJvw= X-Received: by 2002:a50:e0c3:: with SMTP id j3mr22288939edl.97.1637314732247; Fri, 19 Nov 2021 01:38:52 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Fri, 19 Nov 2021 10:38:41 +0100 Message-ID: Subject: Re: [PATCH] Remove MAY_HAVE_DEBUG_MARKER_STMTS and MAY_HAVE_DEBUG_BIND_STMTS. To: Alexandre Oliva Cc: Richard Biener via Gcc-patches , =?UTF-8?Q?Martin_Li=C5=A1ka?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2021 09:38:54 -0000 On Fri, Nov 19, 2021 at 9:59 AM Alexandre Oliva wrote: > > On Oct 18, 2021, Richard Biener via Gcc-patches = wrote: > > > On Mon, Oct 18, 2021 at 10:54 AM Martin Li=C5=A1ka wro= te: > >> > >> The macros correspond 1:1 to an option flags and make it harder > >> to find all usages of the flags. > >> > >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > >> > >> Ready to be installed? > > > Hmm, they were introduced on purpose > > Yup. Though there is a 1:1 equivalence right now, conceptually other > kinds of debug marker stmts, and of debug bind stmts, could be > introduced, and then the macros would be adjusted to encompass the new > functionality, covering presumably different options as well. > > By removing the macros, every use of the options would have to be > reassessed to tell whether it needs to be changed to cover the new > features, or left alone because it's really meant to refer to that > specific option. > > So I find the abstraction useful. However, I don't have plans to add > other kinds of debug stmts, and I don't know of anyone else who does, so > I won't stand in the way if others think removing these abstractions is > a positive change. Since the patch keeps some abstraction but not all I think we should keep them all for now. Richard. > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about