From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id CB92D3858D20 for ; Wed, 31 May 2023 07:24:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB92D3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2af225e5b4bso57399151fa.3 for ; Wed, 31 May 2023 00:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685517846; x=1688109846; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7Q6nD18hYAJSkSlaPLNr/z9pwCGvKBN1c6Q3ott4Ck0=; b=P2GqUFf73FvsC+TSX8OqUXlF4rSSxtMkr4n/SWy4/F6kE6gMTy7R+tWeVKQME4qGHY cdZCAj0fnfyC1id5/6b79jKlWNTZ1NgUirYxmhzlKiOgh27F60OJlhEx0qg8nPlezY2S Xz8pPiU6MKLDOaFK8jB5t5bheSsQhymKQkWTbqcGd8dazdGLBh0TUFFZ9kZ5vh5rp/Q9 nQncGx25g5/kLDLcsc3YF/4tSIif7m9o0t52HconmlJ0BdyW6gKXkHx0GlMIOoVnp7BK pI2fBt6sQoVD17bcW309lyQ40NKuX+6zfw8tZr75aezqKkmkbVTRfXq9fvfBXxNjbpgF anmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685517846; x=1688109846; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7Q6nD18hYAJSkSlaPLNr/z9pwCGvKBN1c6Q3ott4Ck0=; b=FIdmRzhfagt/k15lNgo++Zw0PGCbTrP9GV2NdZtM3U0+6dAPv28m7gEF1DDVidtDU5 gXuOaSV7xapP/OtzpjvoBFkOd/Qlj9h8paet5N7NiqzCPKiech1Vb1TziR2M9sFS7OXF QX76C4tD5gTV8O8vdOVuSANqKLEYZ4EUlh9mX5wJfa+6kWp8SUjfuDpg13puoxg/O6Jo 80e5J1BlTA0wZcPkZEwhn41qpt2ge3TwrKTBDkotjB7MxX9d1pcQl0IuW22xHTRJ7R8G kRfksikNDng17IJbUn3hxaH0qKvGYqMEgcFV+UO5m1YMJWUAuPXZaWZDLOutRpKb7eYI SOlA== X-Gm-Message-State: AC+VfDymGpWNFDSEG5wTQkWvozZMjrmxKmESljlgUOLsFmxX4csoT9Hq gKUQSEaQhjxeYASU+xFE6BLg0Hi1gf26Jn4YMKG0uSHy X-Google-Smtp-Source: ACHHUZ4enkoFYZiAQI4qrBZLzn5jAMUCqE8nnbNGpJPPsmOZJN2lktfpa3BxOJCjyfs0aMovlLdYyihrIVP9YGm2Eqg= X-Received: by 2002:a2e:8382:0:b0:2ad:ad0b:d0fb with SMTP id x2-20020a2e8382000000b002adad0bd0fbmr2096522ljg.30.1685517846203; Wed, 31 May 2023 00:24:06 -0700 (PDT) MIME-Version: 1.0 References: <20230531013525.4133283-1-lili.cui@intel.com> In-Reply-To: <20230531013525.4133283-1-lili.cui@intel.com> From: Richard Biener Date: Wed, 31 May 2023 09:21:52 +0200 Message-ID: Subject: Re: [PATCH] Fix ICE in rewrite_expr_tree_parallel To: "Cui, Lili" Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 31, 2023 at 3:35=E2=80=AFAM Cui, Lili wrot= e: > > Hi, > > This patch is to fix ICE in rewrite_expr_tree_parallel. > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110038 > > Bootstrapped and regtested. Ok for trunk? OK. > Regards > Lili. > > 1. Limit the value of tree-reassoc-width to IntegerRange(0, 256). > 2. Add width limit in rewrite_expr_tree_parallel. > > gcc/ChangeLog: > > PR tree-optimization/110038 > * params.opt: Add a limit on tree-reassoc-width. > * tree-ssa-reassoc.cc > (rewrite_expr_tree_parallel): Add width limit. > > gcc/testsuite/ChangeLog: > > PR tree-optimization/110038 > * gcc.dg/pr110038.c: New test. > --- > gcc/params.opt | 2 +- > gcc/testsuite/gcc.dg/pr110038.c | 10 ++++++++++ > gcc/tree-ssa-reassoc.cc | 3 +++ > 3 files changed, 14 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/gcc.dg/pr110038.c > > diff --git a/gcc/params.opt b/gcc/params.opt > index 66f1c99036a..70cfb495e3a 100644 > --- a/gcc/params.opt > +++ b/gcc/params.opt > @@ -1091,7 +1091,7 @@ Common Joined UInteger Var(param_tracer_min_branch_= ratio) Init(10) IntegerRange( > Stop reverse growth if the reverse probability of best edge is less than= this threshold (in percent). > > -param=3Dtree-reassoc-width=3D > -Common Joined UInteger Var(param_tree_reassoc_width) Param Optimization > +Common Joined UInteger Var(param_tree_reassoc_width) IntegerRange(0, 256= ) Param Optimization > Set the maximum number of instructions executed in parallel in reassocia= ted tree. If 0, use the target dependent heuristic. > > -param=3Dtsan-distinguish-volatile=3D > diff --git a/gcc/testsuite/gcc.dg/pr110038.c b/gcc/testsuite/gcc.dg/pr110= 038.c > new file mode 100644 > index 00000000000..0f578b182ca > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/pr110038.c > @@ -0,0 +1,10 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O --param=3Dtree-reassoc-width=3D256" } */ > + > +unsigned a, b; > + > +void > +foo (unsigned c) > +{ > + a +=3D b + c + 1; > +} > diff --git a/gcc/tree-ssa-reassoc.cc b/gcc/tree-ssa-reassoc.cc > index ad2f528ff07..f8055d59d57 100644 > --- a/gcc/tree-ssa-reassoc.cc > +++ b/gcc/tree-ssa-reassoc.cc > @@ -5510,6 +5510,9 @@ rewrite_expr_tree_parallel (gassign *stmt, int widt= h, bool has_fma, > for (i =3D stmt_num - 2; i >=3D 0; i--) > stmts[i] =3D SSA_NAME_DEF_STMT (gimple_assign_rhs1 (stmts[i+1])); > > + /* Width should not be larger than op_num/2. */ > + width =3D width <=3D op_num / 2 ? width : op_num / 2; > + > /* Build parallel dependency chain according to width. */ > for (i =3D 0; i < width; i++) > { > -- > 2.25.1 >