From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 703AE3857720 for ; Wed, 24 May 2023 09:04:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 703AE3857720 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2af2696fd1cso9444731fa.2 for ; Wed, 24 May 2023 02:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684919082; x=1687511082; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bo9kE7uZjKAv0cxt5HVan3RUlzNZTJntXaFUrpy1WhI=; b=HceCPnzabQvBLK7wyuEiECtkeJ7cIvRTtCMz1+lchoFua2tH2kDv1BL1VAv/rBWGvT xzPoqc7boBoV3qMKNI/L1uTRIV2PL/+uf0DaocN5kk2EgItJ7jW+3PbC8INjdcBrIz6d 5EDbvYqe51fo5wf4P6FFd9HbYt08tPd8YqErwVlDqvZffzgg9Cfpd9zzip+ANXjmq6vW SiuvNAQm6U/4q7BbT3mg5NN+o32ok/CCE32/t9vnlyXwRwkq/n1uHHdPE81h5AkgahdN vTzM8QpNcmsFBCvMkDtw7J+TR/4y1Tx7oOsoU6MABJyKRBpmE6W6a7llbrGRppGARcn7 1G9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684919082; x=1687511082; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bo9kE7uZjKAv0cxt5HVan3RUlzNZTJntXaFUrpy1WhI=; b=fupypLkpQHhl3EzZOSFyddpDuNB43DC1LtJ1obAqptu5ciftYAuH3OrM0NFD1mwQ4I YTmkEmKDIBdpSo0kqItptUV7aI6LzAXRwoYDAOxxRWGitasZSyQfeBC4FGPzMUxv1iIo 0Wx/KSEbIW9GcEK5p5X2KCzm7DAmvLwo8J/KU7TcnZII//bdANxxu1LGjVH0e5QdQ1Oh J0Qc8DeA7OPOP6G41sMTHD5C4USQw2ppIrz8R2gsNb4pDE+mNFvQ8Lgb45hNY0YRvBck FTzZyv5DgjNqKvEOxUdEW+NkoptI3LmE9rFSdU7eYeFisOFkV+IZ47Qqm+qxMCv0TXiy pVLQ== X-Gm-Message-State: AC+VfDx6y82u8MfmIJQYTjAex+j3r6+oYKlEWCgubyPfDYcGbiz4ajvN NURv7S4Tvf2jaxSDKH2Q4WRRXUwBBfObDxi9vpwsfdtR X-Google-Smtp-Source: ACHHUZ7wYdtab+e5/1JJrpM9nd0ra2uiNiLQQt1s3JafqJgfXs8esD5Z+n98PzlFRL0f5DmLHRkK4MduqzzO+dzDSIw= X-Received: by 2002:a2e:7811:0:b0:2ac:85d7:342b with SMTP id t17-20020a2e7811000000b002ac85d7342bmr5706943ljc.29.1684919082469; Wed, 24 May 2023 02:04:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Wed, 24 May 2023 11:02:36 +0200 Message-ID: Subject: Re: [PATCH] [testsuite] require pic for pr103074.c To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org, Rainer Orth , Mike Stump Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 24, 2023 at 7:19=E2=80=AFAM Alexandre Oliva via Gcc-patches wrote: > > > Fix test that uses -fPIC without stating the requirement for PIC > support. > > Bootstrapped on x86_64-linux-gnu. Also tested on ppc- and x86-vx7r2 > with gcc-12. OK. > for gcc/testsuite/ChangeLog > > * gcc.target/i386/pr103074.c: Require fpic support. > --- > gcc/testsuite/gcc.target/i386/pr103074.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gcc/testsuite/gcc.target/i386/pr103074.c b/gcc/testsuite/gcc= .target/i386/pr103074.c > index 276ad82a1de1e..668d9531096dc 100644 > --- a/gcc/testsuite/gcc.target/i386/pr103074.c > +++ b/gcc/testsuite/gcc.target/i386/pr103074.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target fpic } */ > /* { dg-options "-march=3Dbonnell -Os -fPIC -fschedule-insns -w" } */ > > void > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about