From: Richard Biener <richard.guenther@gmail.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Record that -gtoggle is already used in gcc_options.
Date: Fri, 5 Nov 2021 11:23:31 +0100 [thread overview]
Message-ID: <CAFiYyc2qwkTaUknXk-Lf5Q9zCNkJqqc_ETKJgFZedVU4tHeWAQ@mail.gmail.com> (raw)
In-Reply-To: <74cc2f58-1b09-55f1-a8d9-6c02b7523b71@suse.cz>
On Thu, Nov 4, 2021 at 4:11 PM Martin Liška <mliska@suse.cz> wrote:
>
> On 11/4/21 14:09, Richard Biener wrote:
> > But we shouldn't start with the current global options but with ones
> > we saved for
> > optimize attribute/pragma processing, no?
>
> We hit the issue when we combine cmdline and pragma optimize options.
>
> >
> >> Problem of -gtoggle is that it does not directly influence an option, but it negates it.
> >>
> >> That said, I think my patch with gtoggle_used is a reasonable workaround.
> > Well, then we could as well unset flag_gtoggle after processing it, no?
>
> Yeah, that work! :)
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
OK if you add a comment like
/* Make sure to process -gtoggle only once. */
Richard.
> Thanks,
> Martin
next prev parent reply other threads:[~2021-11-05 10:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 14:10 Martin Liška
2021-11-02 14:33 ` Richard Biener
2021-11-02 15:11 ` Martin Liška
2021-11-02 16:45 ` Richard Biener
2021-11-04 12:51 ` Martin Liška
2021-11-04 13:09 ` Richard Biener
2021-11-04 15:11 ` Martin Liška
2021-11-05 10:23 ` Richard Biener [this message]
2021-11-05 12:01 ` Martin Liška
2021-11-02 22:49 ` Andrew Pinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc2qwkTaUknXk-Lf5Q9zCNkJqqc_ETKJgFZedVU4tHeWAQ@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).