public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>
Subject: Re: PR92163
Date: Fri, 25 Oct 2019 08:01:00 -0000	[thread overview]
Message-ID: <CAFiYyc2rQq+43omf9YofmF-59S8F22YWjxDnyPocTU9pdtSVBg@mail.gmail.com> (raw)
In-Reply-To: <CAAgBjMnh1yYPCGo4s8rmbp60OGfnqcLO42zen0ZWQeC8rkk9Tw@mail.gmail.com>

On Wed, Oct 23, 2019 at 11:45 PM Prathamesh Kulkarni
<prathamesh.kulkarni@linaro.org> wrote:
>
> Hi,
> The attached patch tries to fix PR92163 by calling
> gimple_purge_dead_eh_edges from ifcvt_local_dce if we need eh cleanup.
> Does it look OK ?

Hmm.  I think it shows an issue with the return value of remove_stmt_form_eh_lp
which is true if the LP index is -1 (externally throwing).  We don't
need to purge
any edges in that case.  That is, if-conversion should never need to
do EH purging
since that would be wrong-code.

As of the segfault can you please instead either pass down need_eh_cleanup
as function parameter (and NULL from ifcvt) or use the return value in DSE
to set the bit in the caller.

Thanks,
Richard.

> Thanks,
> Prathamesh

  reply	other threads:[~2019-10-25  7:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 21:47 PR92163 Prathamesh Kulkarni
2019-10-25  8:01 ` Richard Biener [this message]
2019-10-25 20:49   ` PR92163 Prathamesh Kulkarni
2019-10-28 14:53     ` PR92163 Richard Biener
2019-10-28 15:06       ` PR92163 Prathamesh Kulkarni
2019-11-04 13:07         ` PR92163 Christophe Lyon
2019-11-05  4:46           ` PR92163 Prathamesh Kulkarni
2019-11-05 13:06             ` PR92163 Christophe Lyon
2019-11-07  6:29               ` PR92163 Prathamesh Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFiYyc2rQq+43omf9YofmF-59S8F22YWjxDnyPocTU9pdtSVBg@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=prathamesh.kulkarni@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).