From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-511725-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 47623 invoked by alias); 25 Oct 2019 07:49:16 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 47535 invoked by uid 89); 25 Oct 2019 07:49:09 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_1,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mail-lj1-f172.google.com
Received: from mail-lj1-f172.google.com (HELO mail-lj1-f172.google.com) (209.85.208.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Oct 2019 07:49:08 +0000
Received: by mail-lj1-f172.google.com with SMTP id v24so1592528ljj.3        for <gcc-patches@gcc.gnu.org>; Fri, 25 Oct 2019 00:49:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=Q+lRRoj2ZgsCt+ufVkTT3TGNExfnXpuR5jYuHRgLv5w=;        b=d7MqSIutO7v5ePymMTy3bx7/LzTU6+9Okyp9yEuYWaum2THYQkULa/qpljRRKGc022         vA8qbqiFHTr8AsF0EoGV1yPTh3JJ1Ub8DznHwYqFm+53NfSYJ0H/otMDv4jNCrELGyuM         Rq9Gs0ChiPD9KiRdmOFToUf2YyGwUhrIi60SLbk8trVWAJQJAD/MgjTEboNJxihDOEGW         Migy7yn792SlJrnVb1qntdMbRFE/8ZeysQ5//u5pwFDvnej4Re/htOk6nqkRbA5egtdm         vOPy605IW239H+tWUMOs+AExpNjD3PvIgikesuFSXFpxS2afSeg0kSKramzzFltnjsUT         r9iQ==
MIME-Version: 1.0
References: <CAAgBjMnh1yYPCGo4s8rmbp60OGfnqcLO42zen0ZWQeC8rkk9Tw@mail.gmail.com>
In-Reply-To: <CAAgBjMnh1yYPCGo4s8rmbp60OGfnqcLO42zen0ZWQeC8rkk9Tw@mail.gmail.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Fri, 25 Oct 2019 08:01:00 -0000
Message-ID: <CAFiYyc2rQq+43omf9YofmF-59S8F22YWjxDnyPocTU9pdtSVBg@mail.gmail.com>
Subject: Re: PR92163
To: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2019-10/txt/msg01796.txt.bz2

On Wed, Oct 23, 2019 at 11:45 PM Prathamesh Kulkarni
<prathamesh.kulkarni@linaro.org> wrote:
>
> Hi,
> The attached patch tries to fix PR92163 by calling
> gimple_purge_dead_eh_edges from ifcvt_local_dce if we need eh cleanup.
> Does it look OK ?

Hmm.  I think it shows an issue with the return value of remove_stmt_form_eh_lp
which is true if the LP index is -1 (externally throwing).  We don't
need to purge
any edges in that case.  That is, if-conversion should never need to
do EH purging
since that would be wrong-code.

As of the segfault can you please instead either pass down need_eh_cleanup
as function parameter (and NULL from ifcvt) or use the return value in DSE
to set the bit in the caller.

Thanks,
Richard.

> Thanks,
> Prathamesh