From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id 4BC753858C27 for ; Wed, 13 Oct 2021 13:29:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4BC753858C27 Received: by mail-ed1-x535.google.com with SMTP id w14so10157141edv.11 for ; Wed, 13 Oct 2021 06:29:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iLQazPbyLDqq9lQDUIiafK2dSoN4iczmDd2Zvo9xboE=; b=Ljx9Zq/0SZxrFpUdAzPRvH+Gu3npRsPDbin0TM7c47GU/3MFW8MCbTBwe81XbnmZAi pOMSEOwZ9CC6C4tsv7akBF6Q5g11/OQ2jK47On4ZxryjCV9+haILl6+E7oL/Mnn2fyZI xCuJRpBX532yFQWLMKqHcVDWmCsuxGKOyObR2ewyWs3CLouLvhCCSzpVkSdDVr3S/TfG obX/dT9MIVxDRwjCXU2Dva6ubn1d+DsnnMheo6xQR/y1rjptWBfQ11bf0Jg0DYOFGesZ YC6b79uKB3vRDioHESMjTbGt5zNlKpfPx1F5nPqaXvTkLpkvw/yzN9LdclNxKaL+bK66 eQIQ== X-Gm-Message-State: AOAM5301wDLQEF9P3hXVqKy1AEYRldIICLRCyJzrvkJQnKgWTKxUDNJv SBI/HHCYEk/oMl9deRz4y0BdC/dPBCKh0p4tQ8o= X-Google-Smtp-Source: ABdhPJyEdqPmgBczOSa7IbatNGfn6hk6g4Gd5QpC3y/H4dYJ3tu05hLo5BB+PnM/ustkamdYE4v1LmK2R6OhjuY6X+o= X-Received: by 2002:a17:906:2412:: with SMTP id z18mr20076117eja.56.1634131767335; Wed, 13 Oct 2021 06:29:27 -0700 (PDT) MIME-Version: 1.0 References: <202e07b3-e8d5-85e2-c0a5-8a40a61d7175@suse.cz> <0ea9882e-8d7c-f6d4-9262-50e2b3ae5e6c@suse.cz> <163c4fd6-5c81-0a4f-5d5a-c2a06c275fa5@suse.cz> In-Reply-To: <163c4fd6-5c81-0a4f-5d5a-c2a06c275fa5@suse.cz> From: Richard Biener Date: Wed, 13 Oct 2021 15:29:16 +0200 Message-ID: Subject: Re: [PATCH] options: Fix variable tracking option processing. To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 13:29:37 -0000 On Wed, Oct 13, 2021 at 3:12 PM Martin Li=C5=A1ka wrote: > > On 10/13/21 14:50, Richard Biener wrote: > > It does, yes. But that's a ^ with flag_var_tracking_assignments_toggle= ;) > > > > It's also one of the more weird flags, so it could be applied after the > > otherwise single set of flag_var_tracking_assignments ... > > Well, it's far from being simple. > Can we please make a step and install the patch I sent? I mean the latest > that does the removal of AUTODETECT_VALUE. But parts of the patch are not obvious and you've not explained why you remove all Init(AUTODETECT_VALUE) but for flag_var_tracking you change it to Init(1). I count 4 assignments to flag_var_tracking in toplev= .c and one in nvptx.c and c6x.c each. if (flag_var_tracking_uninit =3D=3D AUTODETECT_VALUE) flag_var_tracking_uninit =3D flag_var_tracking; can probably be handled by EnabledBy, but then we also have if (flag_var_tracking_uninit =3D=3D 1) flag_var_tracking =3D 1; which suggests the same the other way around. I guess positional handling might differ with say -fvar-tracking -fno-var-tracking-uninit vs. -fno-var-tracking-uninit -fvar-tracking when using EnabledBy vs. the "explicit" code. + else if (!OPTION_SET_P (flag_var_tracking) && flag_var_tracking) flag_var_tracking =3D optimize >=3D 1; I think _this_ should, instead of the Init(1), become an entry in default_options_table with OPT_LEVELS_1_PLUS. As said, besides flag_var_* the posted patch looks OK and is good to commit. Richard. > > Martin