From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 38BB1385AC37 for ; Wed, 30 Jun 2021 10:50:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38BB1385AC37 Received: by mail-ed1-x52f.google.com with SMTP id w13so2648364edc.0 for ; Wed, 30 Jun 2021 03:50:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0VR1s2OBsCx/Nk/ZjZnQ/pCQhQe7+i1lhWO5TdmJIm8=; b=gv/+djn6qAza5xM76gbs28go8W41EK4ggJEn5e9bNBVq3i4gOdwSQsjIXhRnGxFIsh MynldorGXOE3yt14M1a6TC4S4AWuWLTGGkxKWCuFABU71/fXC7rcGWTgxsipTjsaHoVu sullct/78NQnVfxaJsbMcvB4AHp7s/J/BDtXWC1uZaWlXlQIEhy+id8bekvwV1Wr3f0x WJqW6o/dpnVlDNC7zjjEqskYnVD0MCWhcn5Xeg56B6Em/czvO0G8aXeOdyVHVxqPPHDM +t/JRLofZ5jKFLM8/FqrJChZNDTc8pYGrNduJvw30bnWPEwjOMbjB+i7USPc+2DekjwK YfvQ== X-Gm-Message-State: AOAM533aEN281qL5x9c5r1J49w/HiT8sXDJVzqdaAyJ39ZI5iD6+TL/S 4adGY7qdBCRuIx+EkdQyl8RHjPLZP4PPXBMXYMw= X-Google-Smtp-Source: ABdhPJx2b1PBlDo+WS6Dviso+t3S3A6sxhrHomZyEBxcFp38PwOpwLJR+fFPjjwaUwPvD1UQ534DU8SQ+EsOnqaSUeM= X-Received: by 2002:a05:6402:220d:: with SMTP id cq13mr45155299edb.214.1625050257304; Wed, 30 Jun 2021 03:50:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Wed, 30 Jun 2021 12:50:46 +0200 Message-ID: Subject: Re: [RFC PATCH] Change the type of predicates to bool. To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2021 10:50:59 -0000 On Wed, Jun 30, 2021 at 10:47 AM Uros Bizjak via Gcc-patches wrote: > > This RFC patch changes the type of predicates to bool. However, some > of the targets (e.g. x86) use indirect functions to call the > predicates, so without the local change, the build fails. Putting the > patch through CI bots should weed out the problems, but I have no > infrastructure to do it myself. I'd say thanks for the work - note building some cc1 crosses should catch 99% of the fallout (just configure $target-linux/elf and make all-gcc= ) Richard. > 2021-06-30 Uro=C5=A1 Bizjak > > gcc/ > * genpreds.c (write_predicate_subfunction): > Change the type of written subfunction to bool. > (write_one_predicate_function): > Change the type of written function to bool. > (write_tm_preds_h): Ditto. > * recog.h (*insn_operand_predicate_fn): Change the type to bool. > * recog.c (general_operand): Change the type to bool. > (address_operand): Ditto. > (register_operand): Ditto. > (pmode_register_operand): Ditto. > (scratch_operand): Ditto. > (immediate_operand): Ditto. > (const_int_operand): Ditto. > (const_scalar_int_operand): Ditto. > (const_double_operand): Ditto. > (nonimmediate_operand): Ditto. > (nonmemory_operand): Ditto. > (push_operand): Ditto. > (pop_operand): Ditto. > (memory_operand): Ditto. > (indirect_operand): Ditto. > (ordered_comparison_operator): Ditto. > (comparison_operator): Ditto. > > * config/i386/i386-expand.c (ix86_expand_sse_cmp): > Change the type of indirect predicate function to bool. > > Patch was bootstrapped on x86_64-linux-gnu. > > Comments welcome. > > Uros.