From: Richard Biener <richard.guenther@gmail.com>
To: Jeff Law <law@redhat.com>
Cc: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>
Subject: Re: [PATCH] Fix PR64242
Date: Mon, 03 Dec 2018 13:34:00 -0000 [thread overview]
Message-ID: <CAFiYyc2tposVpP7bF7GPSJygi-as7OQj8BwCP6=asw_xttR9UA@mail.gmail.com> (raw)
In-Reply-To: <8d85508a-f679-54fb-af20-4f267b813df0@redhat.com>
On Sat, Dec 1, 2018 at 12:07 AM Jeff Law <law@redhat.com> wrote:
>
> On 11/29/18 12:26 PM, Wilco Dijkstra wrote:
> > Fix PR64242 - the middle end expansion for long jmp updates the
> > hard frame pointer before it reads the new stack pointer. This
> > results in a corrupted stack pointer if the jmp buffer is a local.
> > The obvious fix is to insert a temporary.
> >
> > AArch64 bootstrap & regress pass. OK to commit?
> >
> > ChangeLog:
> > 2018-11-29 Wilco Dijkstra <wdijkstr@arm.com>
> >
> > gcc/
> > PR middle-end/64242
> > * builtins.c (expand_builtin_longjmp): Use a temporary when restoring
> > the frame pointer.
> > (expand_builtin_nonlocal_goto): Likewise.
> >
> > testsuite/
> > PR middle-end/64242
> > * gcc.c-torture/execute/pr64242.c: New test.
> THanks for tracking this down. I'd like to have this run through my
> next testing cycle, so I went ahead and installed it for you.
The testcase runfails on x86_64 with -m32 and -m64.
Richard.
> Thanks again,
> Jeff
next prev parent reply other threads:[~2018-12-03 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 19:26 Wilco Dijkstra
2018-11-30 23:07 ` Jeff Law
2018-12-03 13:34 ` Richard Biener [this message]
2018-12-03 13:40 ` Christophe Lyon
2018-12-03 16:26 ` Jakub Jelinek
2018-12-03 18:53 ` Jeff Law
2018-12-04 10:20 ` Christophe Lyon
2018-12-04 10:23 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc2tposVpP7bF7GPSJygi-as7OQj8BwCP6=asw_xttR9UA@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).