* [PATCH] add calls.c to GTFILES in Makefile.in
@ 2017-03-08 1:04 Martin Sebor
2017-03-14 0:37 ` [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936) Martin Sebor
2017-03-14 22:17 ` [PATCH] add calls.c to GTFILES in Makefile.in Jeff Law
0 siblings, 2 replies; 6+ messages in thread
From: Martin Sebor @ 2017-03-08 1:04 UTC (permalink / raw)
To: Gcc Patch List
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
In bug 79936 - ICE with -Walloc-size-larger-than=32767 the reporter
encountered an ICE on x86_64-apple-darwin10.8.0 caused by GCC source
file that implements the warning accessing a global tree without
having included the file in GTFILES make variable. (Thanks again
to David Malcolm who helped me root cause this bug.)
The attached patch fixes this by adding calls.c to the variable and
by including the requisite generated header, gt-calls.h, at the end
of the source.
Martin
[-- Attachment #2: gcc-79936.diff --]
[-- Type: text/x-patch, Size: 940 bytes --]
PR c/79936 - [7 Regression] ICE with -Walloc-size-larger-than=32767
gcc/ChangeLog:
PR c/79936
* Makefile.in (GTFILES): Add calls.c.
* calls.c (must_pass_in_stack_var_size_or_pad): Include "gt-calls.h".
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 8648d68..481515a 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -2517,6 +2517,7 @@ GTFILES = $(CPP_ID_DATA_H) $(srcdir)/input.h $(srcdir)/coretypes.h \
$(srcdir)/ipa-devirt.c \
$(srcdir)/internal-fn.h \
$(srcdir)/hsa-common.c \
+ $(srcdir)/calls.c \
@all_gtfiles@
# Compute the list of GT header files from the corresponding C sources,
diff --git a/gcc/calls.c b/gcc/calls.c
index 6d5ef4e..61caf4c 100644
--- a/gcc/calls.c
+++ b/gcc/calls.c
@@ -5649,3 +5649,6 @@ must_pass_in_stack_var_size_or_pad (machine_mode mode, const_tree type)
return false;
}
+
+/* Tell the garbage collector about GTY markers in this source file. */
+#include "gt-calls.h"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936)
2017-03-08 1:04 [PATCH] add calls.c to GTFILES in Makefile.in Martin Sebor
@ 2017-03-14 0:37 ` Martin Sebor
2017-03-14 9:01 ` Richard Biener
2017-03-14 22:17 ` [PATCH] add calls.c to GTFILES in Makefile.in Jeff Law
1 sibling, 1 reply; 6+ messages in thread
From: Martin Sebor @ 2017-03-14 0:37 UTC (permalink / raw)
To: Gcc Patch List
Ping: this a P3 regression targeted at 7.0.1. It was found
on x86_64-apple-darwin10.8.0 but affects all targets (even
if it doesn't happen to manifest on them):
https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00342.html
On 03/07/2017 06:03 PM, Martin Sebor wrote:
> In bug 79936 - ICE with -Walloc-size-larger-than=32767 the reporter
> encountered an ICE on x86_64-apple-darwin10.8.0 caused by GCC source
> file that implements the warning accessing a global tree without
> having included the file in GTFILES make variable. (Thanks again
> to David Malcolm who helped me root cause this bug.)
>
> The attached patch fixes this by adding calls.c to the variable and
> by including the requisite generated header, gt-calls.h, at the end
> of the source.
>
> Martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936)
2017-03-14 0:37 ` [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936) Martin Sebor
@ 2017-03-14 9:01 ` Richard Biener
2017-03-14 15:52 ` Jeff Law
0 siblings, 1 reply; 6+ messages in thread
From: Richard Biener @ 2017-03-14 9:01 UTC (permalink / raw)
To: Martin Sebor; +Cc: Gcc Patch List
On Tue, Mar 14, 2017 at 1:37 AM, Martin Sebor <msebor@gmail.com> wrote:
> Ping: this a P3 regression targeted at 7.0.1. It was found
> on x86_64-apple-darwin10.8.0 but affects all targets (even
> if it doesn't happen to manifest on them):
>
> https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00342.html
I think you need to include gt-calls.h at the bottom of the file. See other
GTFILES
> On 03/07/2017 06:03 PM, Martin Sebor wrote:
>>
>> In bug 79936 - ICE with -Walloc-size-larger-than=32767 the reporter
>> encountered an ICE on x86_64-apple-darwin10.8.0 caused by GCC source
>> file that implements the warning accessing a global tree without
>> having included the file in GTFILES make variable. (Thanks again
>> to David Malcolm who helped me root cause this bug.)
>>
>> The attached patch fixes this by adding calls.c to the variable and
>> by including the requisite generated header, gt-calls.h, at the end
>> of the source.
>>
>> Martin
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936)
2017-03-14 9:01 ` Richard Biener
@ 2017-03-14 15:52 ` Jeff Law
2017-03-17 11:46 ` Richard Biener
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Law @ 2017-03-14 15:52 UTC (permalink / raw)
To: Richard Biener, Martin Sebor; +Cc: Gcc Patch List
On 03/14/2017 03:01 AM, Richard Biener wrote:
> On Tue, Mar 14, 2017 at 1:37 AM, Martin Sebor <msebor@gmail.com> wrote:
>> Ping: this a P3 regression targeted at 7.0.1. It was found
>> on x86_64-apple-darwin10.8.0 but affects all targets (even
>> if it doesn't happen to manifest on them):
>>
>> https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00342.html
>
> I think you need to include gt-calls.h at the bottom of the file. See other
> GTFILES
But the patch does include gt-calls.h at the end of calls.c, which is
consistent with other uses.
Or did you have something else in mind?
jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] add calls.c to GTFILES in Makefile.in
2017-03-08 1:04 [PATCH] add calls.c to GTFILES in Makefile.in Martin Sebor
2017-03-14 0:37 ` [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936) Martin Sebor
@ 2017-03-14 22:17 ` Jeff Law
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Law @ 2017-03-14 22:17 UTC (permalink / raw)
To: Martin Sebor, Gcc Patch List
On 03/07/2017 06:03 PM, Martin Sebor wrote:
> In bug 79936 - ICE with -Walloc-size-larger-than=32767 the reporter
> encountered an ICE on x86_64-apple-darwin10.8.0 caused by GCC source
> file that implements the warning accessing a global tree without
> having included the file in GTFILES make variable. (Thanks again
> to David Malcolm who helped me root cause this bug.)
>
> The attached patch fixes this by adding calls.c to the variable and
> by including the requisite generated header, gt-calls.h, at the end
> of the source.
>
> Martin
>
> gcc-79936.diff
>
>
> PR c/79936 - [7 Regression] ICE with -Walloc-size-larger-than=32767
>
> gcc/ChangeLog:
>
> PR c/79936
> * Makefile.in (GTFILES): Add calls.c.
> * calls.c (must_pass_in_stack_var_size_or_pad): Include "gt-calls.h".
I fixed the ChangeLog entry for calls.c and installed this.
Thanks,
jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936)
2017-03-14 15:52 ` Jeff Law
@ 2017-03-17 11:46 ` Richard Biener
0 siblings, 0 replies; 6+ messages in thread
From: Richard Biener @ 2017-03-17 11:46 UTC (permalink / raw)
To: Jeff Law; +Cc: Martin Sebor, Gcc Patch List
On Tue, Mar 14, 2017 at 4:52 PM, Jeff Law <law@redhat.com> wrote:
> On 03/14/2017 03:01 AM, Richard Biener wrote:
>>
>> On Tue, Mar 14, 2017 at 1:37 AM, Martin Sebor <msebor@gmail.com> wrote:
>>>
>>> Ping: this a P3 regression targeted at 7.0.1. It was found
>>> on x86_64-apple-darwin10.8.0 but affects all targets (even
>>> if it doesn't happen to manifest on them):
>>>
>>> https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00342.html
>>
>>
>> I think you need to include gt-calls.h at the bottom of the file. See
>> other
>> GTFILES
>
> But the patch does include gt-calls.h at the end of calls.c, which is
> consistent with other uses.
>
> Or did you have something else in mind?
Eh, no. Just didn't spot that part...
Patch is ok.
Richard.
> jeff
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-17 11:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-08 1:04 [PATCH] add calls.c to GTFILES in Makefile.in Martin Sebor
2017-03-14 0:37 ` [PATCH] add calls.c to GTFILES in Makefile.in (PR 79936) Martin Sebor
2017-03-14 9:01 ` Richard Biener
2017-03-14 15:52 ` Jeff Law
2017-03-17 11:46 ` Richard Biener
2017-03-14 22:17 ` [PATCH] add calls.c to GTFILES in Makefile.in Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).