From: Richard Biener <richard.guenther@gmail.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Mikhail Maltsev <maltsevm@gmail.com>,
gcc-patches mailing list <gcc-patches@gcc.gnu.org>,
mliska <mliska@suse.cz>, Jeff Law <law@redhat.com>
Subject: Re: [PATCH] Use single shared memory block pool for all pool allocators
Date: Mon, 27 Jul 2015 09:19:00 -0000 [thread overview]
Message-ID: <CAFiYyc2vA3tptVYR_JR=wTjYkBF44FbrhB=EM39Aj1zGZxAFUA@mail.gmail.com> (raw)
In-Reply-To: <2378E38A-ACE5-47BB-8A45-BEE3F8486E49@gmail.com>
On Sun, Jul 26, 2015 at 9:09 PM, <pinskia@gmail.com> wrote:
>
>
>
>
>> On Jul 26, 2015, at 11:50 AM, Andi Kleen <andi@firstfloor.org> wrote:
>>
>> Mikhail Maltsev <maltsevm@gmail.com> writes:
>>
>>> Hi, all!
>>> Recently I did some profiling of GCC to find hotspots and areas of possible
>>> performance improvement among them. glibc malloc(3) is one of (perhaps
>>> known)
>>
>> I've been compiling gcc with tcmalloc to do a similar speedup. It would be
>> interesting to compare that to your patch.
>>
>> Another useful optimization is to adjust the allocation size to be >=
>> 2MB. Then modern Linux kernels often can give you a large page,
>> which cuts down TLB overhead. I did similar changes some time
>> ago for the garbage collector.
>
> Unless you are running with 64k pages which I do all the time on my armv8 system.
This can be a host configurable value of course.
But first of all (without looking at the patch but just reading the
description) this
sounds like a good idea. Maybe still allow pools to use their own backing if
the object size is larger than the block size of the caching pool?
Thanks,
Richard.
> Thanks,
> Andrew
>
>
>>
>> BTW I saw big differences in larger LTO builds.
>>
>> -Andi
>>
>> --
>> ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2015-07-27 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-26 18:50 Mikhail Maltsev
2015-07-26 19:38 ` Andi Kleen
2015-07-26 19:59 ` pinskia
2015-07-27 9:19 ` Richard Biener [this message]
2015-08-03 8:41 ` Mikhail Maltsev
2015-08-17 7:31 ` [PATCH] [ping] " Mikhail Maltsev
2015-08-25 21:02 ` Richard Sandiford
2015-08-31 11:45 ` Richard Biener
2015-09-16 1:07 ` Mikhail Maltsev
2015-08-31 7:24 ` [PING^2][PATCH] " Mikhail Maltsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc2vA3tptVYR_JR=wTjYkBF44FbrhB=EM39Aj1zGZxAFUA@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=andi@firstfloor.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=maltsevm@gmail.com \
--cc=mliska@suse.cz \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).