From: Richard Biener <richard.guenther@gmail.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
Bernd Schmidt <bschmidt@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Fold acc_on_device
Date: Thu, 01 Oct 2015 12:46:00 -0000 [thread overview]
Message-ID: <CAFiYyc2wEMr7Ci+WRwPBNzH8hnarW1vMgTWyDAL=jS006gaiyg@mail.gmail.com> (raw)
In-Reply-To: <560D2803.5080304@acm.org>
On Thu, Oct 1, 2015 at 2:33 PM, Nathan Sidwell <nathan@acm.org> wrote:
> On 10/01/15 06:03, Richard Biener wrote:
>>
>> On Wed, Sep 30, 2015 at 9:22 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>
>
>>> Wouldn't it be better to just emit GIMPLE here instead?
>>> So
>>> tree res = make_ssa_name (boolean_type_node);
>>> gimple g = gimple_build_assign (res, EQ_EXPR, arg0,
>>> build_int_cst (integer_type_node,
>>> val_host));
>>> gsi_insert_before (gsi, g);
>>> ...
>
>
> Like this?
+ gimple *host_ass = gimple_build_assign
+ (host_eq, EQ_EXPR, arg0, build_int_cst (integer_type_node, val_host));
use TREE_TYPE (arg0) for the integer cst.
Otherwise looks good to me.
Thanks,
Richard.
> nathan
next prev parent reply other threads:[~2015-10-01 12:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 18:50 Nathan Sidwell
2015-09-29 20:22 ` Bernd Schmidt
2015-09-29 20:29 ` Nathan Sidwell
2015-09-30 8:55 ` Richard Biener
2015-09-30 12:40 ` Nathan Sidwell
2015-09-30 12:40 ` Bernd Schmidt
2015-09-30 12:57 ` Richard Biener
2015-09-30 14:17 ` Nathan Sidwell
2015-09-30 19:23 ` Nathan Sidwell
2015-09-30 20:00 ` Jakub Jelinek
2015-10-01 10:03 ` Richard Biener
2015-10-01 12:33 ` Nathan Sidwell
2015-10-01 12:46 ` Richard Biener [this message]
2015-10-01 14:14 ` Nathan Sidwell
2015-10-06 6:13 ` Segher Boessenkool
2015-10-06 14:04 ` Nathan Sidwell
2015-10-01 17:00 ` Andrew MacLeod
2015-10-01 17:11 ` Nathan Sidwell
2015-10-01 21:08 ` Andrew MacLeod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc2wEMr7Ci+WRwPBNzH8hnarW1vMgTWyDAL=jS006gaiyg@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).