From: Richard Biener <richard.guenther@gmail.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
Date: Mon, 12 Aug 2019 11:01:00 -0000 [thread overview]
Message-ID: <CAFiYyc2wU3wngdS3evggSE9xCyHCcnPmVY=12aeTGqmacQQzFw@mail.gmail.com> (raw)
In-Reply-To: <CAFiYyc1vTghPTsxxDKhMWeAt-1vD00uULMrCej=dZOMebNjfeQ@mail.gmail.com>
On Mon, Aug 12, 2019 at 12:49 PM Richard Biener
<richard.guenther@gmail.com> wrote:
>
> On Mon, Aug 12, 2019 at 12:43 PM Martin Liška <mliska@suse.cz> wrote:
> >
> > On 8/12/19 12:39 PM, Richard Biener wrote:
> > > which is the "other" body for 'open' but it shouldn't really be output
> > > to the symbol table. Still we want to emit its body for the purpose
> > > of inlining. So IMHO the fix is not to do magic '0' appending for
> > > the user-asm-name case but instead "mangling" of extern inline
> > > bodies because those are the speciality causing the issue in the end.
> >
> > Ok, so please advise me how can we achieve that?
>
> I'd change lto_get_section_name to take the fndecl instead of name
> and key on DECL_EXTERNAL/DECL_INLINE (or how we identify
> extern gnu-inline functions), pre-pending a zero.
Or even "simpler"(?) by mangling DECL_ASSEMBLER_NAME for
these functions throughout GCC - they should never be emitted.
Honza?
Richard.
> Richard.
>
> > Martin
next prev parent reply other threads:[~2019-08-12 10:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 15:19 Martin Liška
2019-08-12 10:39 ` Richard Biener
2019-08-12 10:43 ` Martin Liška
2019-08-12 10:46 ` Richard Biener
2019-08-12 10:50 ` Martin Liška
2019-08-12 10:58 ` Richard Biener
2019-08-12 11:01 ` Richard Biener [this message]
2019-08-12 10:52 ` Richard Biener
2019-08-15 14:57 ` Jan Hubicka
2019-08-16 9:11 ` Richard Biener
2019-08-23 13:20 ` Martin Liška
2019-08-23 14:00 ` Martin Liška
2019-08-23 15:39 ` Jan Hubicka
2019-08-23 15:43 ` Martin Liška
2019-08-23 16:32 ` Jan Hubicka
2019-08-23 16:42 ` Martin Liška
2019-08-23 23:18 ` Jan Hubicka
2019-08-26 11:54 ` Martin Liška
2019-09-09 12:39 ` Martin Liška
2019-09-09 14:33 ` Jan Hubicka
2019-09-11 11:38 ` Martin Liška
2019-09-18 10:14 ` Martin Liška
2019-10-22 11:15 ` Martin Liška
2019-10-29 11:34 ` Martin Liška
2019-10-29 14:51 ` Jan Hubicka
2019-10-30 10:11 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc2wU3wngdS3evggSE9xCyHCcnPmVY=12aeTGqmacQQzFw@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).