From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39050 invoked by alias); 20 Oct 2016 12:10:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 38996 invoked by uid 89); 20 Oct 2016 12:10:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hum, anyhow, gofrontend-dev, HX-Gm-Message-State:sk:ABUngvc X-HELO: mail-qk0-f194.google.com Received: from mail-qk0-f194.google.com (HELO mail-qk0-f194.google.com) (209.85.220.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Oct 2016 12:10:24 +0000 Received: by mail-qk0-f194.google.com with SMTP id v138so4339705qka.2 for ; Thu, 20 Oct 2016 05:10:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7kWsCSdxKtI5LtzHyLXEtiBpAB22fCrhH9dBMzBoZPg=; b=m+xPIF9Wy6lmdsz1yiskI1Zt3zT4sfEs4TDM9WrBYl2VmB6GYRDF5rNI/iwRjiHoQI PiAaJeTRixiJTPCHJbxEUh+oWqA/ZY7uN+dJMsN+JwAF7hmHf8UflW7XUFFrjF4d94fd VncZxiPDjugllFYMSeRxySrYCO/y2zKUi8ZlcA/p674PwAfzbACwFAcwWj9fMFOjjbkc 6Juhev81vioyOu76EhR6PUITZKDO4SIt1O7BgUoJSM4/C6PmXGeEW3lsYW295H020QD8 3Yglt8L7mCaD/4sGvUDPbH9+/TeIgLVS5hNKbVXL/F2Hou1hkTkTb73taWWA5tfRpWhK 45kg== X-Gm-Message-State: ABUngvcFo8QPbndY4IRLwr90cekMeBEf1+Xo2SxuWAs8IT27jg4ob2x4SpAin9NqIr9fQNOIO7ET2LgnbT2M1g== X-Received: by 10.194.81.133 with SMTP id a5mr241026wjy.86.1476965422480; Thu, 20 Oct 2016 05:10:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.155.146 with HTTP; Thu, 20 Oct 2016 05:10:21 -0700 (PDT) In-Reply-To: References: From: Richard Biener Date: Thu, 20 Oct 2016 12:10:00 -0000 Message-ID: Subject: Re: [gofrontend-dev] Re: libgo patch committed: copy rdebug code from Go 1.7 To: Ian Lance Taylor Cc: gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg01635.txt.bz2 On Wed, Oct 19, 2016 at 6:53 PM, Ian Lance Taylor wrote: > On Wed, Oct 19, 2016 at 6:23 AM, Richard Biener > wrote: >> On Wed, Oct 19, 2016 at 3:17 PM, Ian Lance Taylor wrote: >>> On Wed, Oct 19, 2016 at 4:30 AM, Richard Biener >>> wrote: >>>> On Mon, Oct 17, 2016 at 6:54 PM, Ian Lance Taylor wrote: >>>>> This patch to libgo copies the rdebug code from the Go 1.7 runtime to libgo. >>>>> >>>>> While we're at it, this updates the runtime/debug package, and starts >>>>> running its testsuite by default. I'm not sure why runtime/debug was >>>>> not previously updated to 1.7. Doing that led me to fix some minor >>>>> aspects of runtime.Stack and the C function runtime/debug.readGCStats. >>>>> >>>>> Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed >>>>> to mainline. >>>> >>>> Not sure which of the merges broke it but I get >>>> >>>> ... >>>> rc/svn/trunk2/libgo/go/runtime/time.go >>>> /space/rguenther/src/svn/trunk2/libgo/go/runtime/trace.go >>>> /space/rguenther/src/svn/trunk2/libgo/go/runtime/traceback_gccgo.go >>>> /space/rguenther/src/svn/trunk2/libgo/go/runtime/type.go >>>> /space/rguenther/src/svn/trunk2/libgo/go/runtime/typekind.go >>>> /space/rguenther/src/svn/trunk2/libgo/go/runtime/write_err.go >>>> runtime_sysinfo.go -fPIC -o .libs/runtime-go.o >>>> /space/rguenther/src/svn/trunk2/libgo/go/runtime/netpoll_epoll.go:52:49: >>>> error:integer constant overflow >>>> ev.events = _EPOLLIN | _EPOLLOUT | _EPOLLRDHUP | _EPOLLET >>>> ^ >>>> make[4]: *** [runtime-go.lo] Error 1 >>>> >>>> now and bootstrap is broken for me. This is on x86_64-linux, SLES 11 >>>> SP4 which uses glibc 2.11.3. >>> >>> Is this the 32-bit or 64-bit build? >> >> Hum, don't remember ... >> >>> What is the output of >>> >>> find x86_64-pc-linux-gnu -name runtime_sysinfo.go | xargs grep EPOLLET >>> >>> in your build directory? >> >> x86_64-pc-linux-gnu/32/libgo/runtime_sysinfo.go:const _EPOLLET = -2147483648 >> x86_64-pc-linux-gnu/libgo/runtime_sysinfo.go:const _EPOLLET = -2147483648 >> >> looks like the culprit. All other _EPOLL* constants are positive > > I have not been able to recreate the problem. Perhaps the definition > of EPOLLET in your file is different; on my system the > definition is > > EPOLLET = 1u << 31 > > In any case, I have committed this patch which I believe will fix the > problem. Bootstrapped and tested on x86_64-pc-linux-gnu on a system > that does not show the problem anyhow. Seems to work now. Thanks, Richard. > Ian