From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id 325A63858D35 for ; Tue, 30 Apr 2024 07:42:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 325A63858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 325A63858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::230 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714462923; cv=none; b=se8urq7md3GFpnJRtJOuVrMZZLeP1zkgmeDFYxxFv3kfxKKO0t8Dc3VtrMfSvUjSlLmyRXeCbLj3ur3zI83JJDnPK92xfFly7b4MkvD2aQ0N1yNTSVC0EoVvFHopdkmyHdzmAfAnCLQPeGw+WpTKCxHF3Rly5Jzeb9wNCXFj0Zk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714462923; c=relaxed/simple; bh=F9I+OGgFUCh1c7Hh43g+9KTZapzSfZ5WNuE3mQkF0Lw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=vJgX2nsQbP7IVNbczx/mH6a1uXG5bcydr2LwtRKoo0gs6juDipHGhGKQvXt+jlYULvnDIIYoHsaSnI4eoFWrQikhk44nBtjqQXsFvuMV462ul1D+McZ5q4P1S+RfB9nNDZbG3CMwSGrdXZpV7wWOM3PsNQTuXxpcYP/7WywWhb4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2df83058d48so40377931fa.1 for ; Tue, 30 Apr 2024 00:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714462920; x=1715067720; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fp8E5NyYudVGVSxHgdHqRjBXKCEZ1qzq6OC5NyFLrrs=; b=SjT2qfHx2GEUgM2XOuuFv+a6OoU2Tsdu8wdblPmxQxTz1qnwYVIhuoaDXN0H8PSpZw 7Ls+YtV9ZMGUhwPHY6j90BDHPyaJj8tqRSBp+WkoQPg23U5i5Ze/KruPCYH6b20+Eftt 3oEXFzEQ+41ctA+4eCwsLOQ3VCStebl+lhenQapyIjRpmIF0a/mK3B4BbJW0YLZZAY7l Am+EkvKho//8Hbs2tRIYcy2GxRxfJV5Ms1fKroyiqVodZSkYDEteTdKQribw1SDp2fgL cmY7uzCyxWThLDAgiKpO18UetVYPqesUxjErbTP0rMDecOkgPGtCuKj0f3OGyWU8LmXn Utpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714462920; x=1715067720; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fp8E5NyYudVGVSxHgdHqRjBXKCEZ1qzq6OC5NyFLrrs=; b=m1o/6IzjHrlxx8bpmt1orQU01Ho/l0xGIthlBIDakkHaLZAqzYTsUfCgtn6xNwU9OR zbJsFwMYExfLANLFZTzsmLGVsmlNJDGciktEHaA3f3MKPfIiHrB0BwhMl9It3qqmvcFu A4xft7Ksm1cd6I+bMr+KVekxRdUynQwVl5x0Kxp8H1C1bl9Y5pP7sGLNkyJ3leR8XnyP VHT3a9+QhVoDmhi/lcnwFIUTnMv+AQ1d1/ht2Ieum5g72R6y3WkfY+bDCf8m/Pl9kIbz R6pbbdyxckdfTkhhxxT43yDPURVccagtgDAcTu4p/LypGgxKffuf9uzuHta3NX8kJdZC tXRg== X-Gm-Message-State: AOJu0YzZO6gXHzORMULyWUaWk/PZeKhlo1RZwKLxjFmizukQBDnwGm5p 6pmkppVNPvRAUdcJIJ9gVPbrHBfC+Z9kGLFjvVpf1zq+o/68DCAZcLLIzxNoJq36qoZ/oUkEPJT 1mJigAsvCD7+s/eGxKc5QnRLWuVPOqQ== X-Google-Smtp-Source: AGHT+IEOOlyh7a3K2XaVC72OROXv+B8ADscjAn5xZDELcJR4Apd4TdpOyeyf+Ggn58+HqmYbq22ZD17o7uznLPRjMHU= X-Received: by 2002:a05:651c:794:b0:2df:4a6a:a195 with SMTP id g20-20020a05651c079400b002df4a6aa195mr1022010lje.11.1714462920422; Tue, 30 Apr 2024 00:42:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Tue, 30 Apr 2024 09:41:49 +0200 Message-ID: Subject: Re: [PATCH] make -freg-struct-return visibly a negative alias of -fpcc-struct-return To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Apr 28, 2024 at 10:24=E2=80=AFAM Alexandre Oliva wrote: > > > The fact that both options accept negative forms suggests that maybe > they aren't negative forms of each other. They are, but that isn't > clear even by examining common.opt. Use NegativeAlias to make it > abundantly clear. > > The 'Optimization' keyword next to freg-struct-return was the only > thing that caused flag_pcc_struct_return to be a per-function flag, > and ipa-inline relied on that. After making it an alias, the > Optimization keyword was no longer operational. I'm not sure it was > sensible or desirable for flag_pcc_struct_return to be a per-function > setting, but this patch does not intend to change behavior. > > Regstrapped on x86_64-linux-gnu and ppc64le-linux-gnu. Ok to install? OK. Thanks, Richard. > > for gcc/ChangeLog > > * common.opt (freg-struct-return): Make it explicitly > fpcc-struct-return's NegativeAlias. Copy Optimization... > (freg-struct-return): ... here. > --- > gcc/common.opt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/common.opt b/gcc/common.opt > index ad3488447752b..12d93c76a1e63 100644 > --- a/gcc/common.opt > +++ b/gcc/common.opt > @@ -2406,7 +2406,7 @@ Common RejectNegative Joined UInteger Optimization > -fpack-struct=3D Set initial maximum structure member alignment. > > fpcc-struct-return > -Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN) > +Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN) Opt= imization > Return small aggregates in memory, not registers. > > fpeel-loops > @@ -2596,7 +2596,7 @@ Common Var(flag_record_gcc_switches) > Record gcc command line switches in the object file. > > freg-struct-return > -Common Var(flag_pcc_struct_return,0) Optimization > +Common NegativeAlias Alias(fpcc_struct_return) Optimization > Return small aggregates in registers. > > fregmove > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > More tolerance and less prejudice are key for inclusion and diversity > Excluding neuro-others for not behaving ""normal"" is *not* inclusive