From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 91C9A385842C for ; Tue, 10 Jan 2023 10:08:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 91C9A385842C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x12a.google.com with SMTP id bt23so17538136lfb.5 for ; Tue, 10 Jan 2023 02:08:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0Pp4bfhbMFS7rgu40I7spqCoMpqS4+5J3x92KZ0aECc=; b=T2r4n9084sojSqZHaX8CN0NSg3Hs9Na8mOjbGQO3pgoqRgpnS//rdW1nNEq20WFtTY nnFmHDhqNjBctJ26IZ1Wdi4RPFaJWeV8OGFz2YAAzJ8beDtZbCmSXj9t5nhivfDSZCSJ n9H6+oa80Zuh9h9xj5baEv6aXNcaEroofKrLjfhYF2qpdy+eiKWiPe3kzn3YDjBwXM2s +XipzqxcvdoCoHT2JvKC1TmA2ix4LLempw2OWUMrnwO2JFnotX8Y6ELpVXDjjLLFm8MP j+c5mgE7BaXXhXYZpatMz6Ek0+y5gv4bh77nqf1Nr0PTdDns6ePlYvjEqBvjRsYIhabk TmJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0Pp4bfhbMFS7rgu40I7spqCoMpqS4+5J3x92KZ0aECc=; b=yYecqEusnAmBSGB9xaQJIEhgGgV+lQi9BLhs4DkbeYcdijG09b0tD3HqCK0CjC4ss3 WBztvTc1/U9f46vSZjRhCe1QBWAm3ZL+n9C2CIvFNAqUAaXxD2CeeoRjoOWbWltBMtur osJ6Y0VakuXK+AoImqiJpi3J/cHNfd+xzpLY8wRJ/qTQbH8vbzbZpM3L1HsoO6qamxSL maCrYM7Gme8Z5H59/YMHtDuIJgbZl3cuy/9oPzBeEIRb3nlcorh6TPDREkxZdHdwUL6t OSLMRKH0sapcIAFyicmnjjl62y5l4fnNfr6i9oX5PHNf6QrCTxtxRtJlQyzp0sNj5SXr wTOQ== X-Gm-Message-State: AFqh2kodR3l6psthA4P+OHFHUXtDsdLX88IpEnphGeFSDXrvVPLSRswu XlXMSxU7qdZ6tydP+VE6KFlZJ7o2fbkBAScdBMZRI/vd X-Google-Smtp-Source: AMrXdXsbEkVZUhzIFIhGzKRUrG6vTV9qfGpqQX3cgvJp78Pet4C3o5T8i5JM6lJCttaBCHYbNDNaCRR++9Tq+qdHUlU= X-Received: by 2002:a05:6512:3c88:b0:4b3:a022:2176 with SMTP id h8-20020a0565123c8800b004b3a0222176mr4482462lfv.395.1673345286602; Tue, 10 Jan 2023 02:08:06 -0800 (PST) MIME-Version: 1.0 References: <004e01d92463$7eca2700$7c5e7500$@nextmovesoftware.com> In-Reply-To: <004e01d92463$7eca2700$7c5e7500$@nextmovesoftware.com> From: Richard Biener Date: Tue, 10 Jan 2023 11:07:54 +0100 Message-ID: Subject: Re: [PATCH] PR rtl-optimization/106421: ICE in bypass_block from non-local goto. To: Roger Sayle Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 9, 2023 at 8:50 PM Roger Sayle wrote: > > > This patch fixes PR rtl-optimization/106421, an ICE-on-valid (but > undefined) regression. The fix, as proposed by Richard Biener, is to > defend against BLOCK_FOR_INSN returning NULL in cprop's bypass_block. > > This patch has been tested on x86_64-pc-linux-gnu with make bootstrap > and make -k check, both with and without --target_board=unix{-m32}, > with no new failures. Ok for mainline? OK. > > 2023-01-09 Roger Sayle > > gcc/ChangeLog > PR rtl-optimization/106421 > * cprop.cc (bypass_block): Check that DEST is local to this > function (non-NULL) before calling find_edge. > > gcc/testsuite/ChangeLog > PR rtl-optimization/106421 > * gcc.dg/pr106421.c: New test case. > > > Thanks in advance, > Roger > -- >