From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636])
	by sourceware.org (Postfix) with ESMTPS id 9A2633858298
	for <gcc-patches@gcc.gnu.org>; Wed, 14 Sep 2022 08:28:43 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A2633858298
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ej1-x636.google.com with SMTP id 13so3973330ejn.3
        for <gcc-patches@gcc.gnu.org>; Wed, 14 Sep 2022 01:28:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date;
        bh=Ed8CtRg1LtxPQ6ANY6BFJBs7vqDtr/45ndXYV4w/YVg=;
        b=CO8h7Ygl2PNepKuhjKqq9boUAbxVmAwaLUidlvg7smf1zUe9be8HApruj1Mgt4SHQm
         XVFDJ6dFY3Evz3wTy0N9s2SC+BE0+vp70VZuS64c6uupp9B/zKvLmd9B39qIkyXXEuLy
         N6GQc2d0KSJE/+v47mkVSTQjBzYvm0YOEWMsMIjqH2BQJD7vXv9zrjKB7qkaQLkUkE7H
         TAoICHWJXgqNGKxcnfsx28hbtqM9hUtaDuagi4XCh1U/gS3HJoQ96VSlD7sLDXNiavMX
         v1OajxDYFhm3bHdc4vooHihjy3/nePRa78Pt46f+R1nMM9Dph5ODaCF4Ut6Ibk3vZzqG
         x+Kw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date;
        bh=Ed8CtRg1LtxPQ6ANY6BFJBs7vqDtr/45ndXYV4w/YVg=;
        b=P3cwns5txNjlCuyY6PXWAtwgrKN6Dl8n+Y3x5XBW8cYW4bI1BXeeBPpuBBPbSFTaZh
         LuSMmXOk85YPAXmUGGGpE4i8OYiWzTEY4cgH5RguTW66OBWC5uNnMRIham0Cs/9RKaLe
         2gO2Gv2A3AsVWj+jOkQX94EYn8fRyXddDf9kXzwZkm/WSR0fe9XYFCtxGKCzA2Hk3KaJ
         BQ8uGJpfB737FMtTQdLnk0ON3OGd//Ro+hpcbsGkBtL6WBh+zDY0iivI9SXPxehYFZ8t
         I0ui5PJEKpT/QGBJ+xQOo5tWxkdw5AAaGZ2Qn6H5Jzd0fXvclhPB81dLXogJcEGik8oP
         UkPA==
X-Gm-Message-State: ACgBeo0CR4VkZEWK+J+pjrtguYqwwP165PUg3XtzP5TqxxMMDy8zFiKb
	0XGmVQbtcc+ZqZQS5IrM2xGS1ScFgRpLR0qKSox80CIL
X-Google-Smtp-Source: AA6agR5beOpwrYKvbT8tWOoBv6fkY8YrZ9M+FZQlTEpiSSsZael3FC6pRNAM+FlY4H30p3MPV3cYVfbvLD8PseLVjEM=
X-Received: by 2002:a17:907:3e12:b0:738:fd2f:df80 with SMTP id
 hp18-20020a1709073e1200b00738fd2fdf80mr25710048ejc.29.1663144122474; Wed, 14
 Sep 2022 01:28:42 -0700 (PDT)
MIME-Version: 1.0
References: <002d01d8c79f$dc5fe830$951fb890$@nextmovesoftware.com>
In-Reply-To: <002d01d8c79f$dc5fe830$951fb890$@nextmovesoftware.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Wed, 14 Sep 2022 10:28:30 +0200
Message-ID: <CAFiYyc2zjStxUqR=JO6Tpgfx0Rn6pitxXZPiWHxUzc7JW5N8LQ@mail.gmail.com>
Subject: Re: [PATCH] Optimize (X<<C)+(Y<<C) as (X+Y)<<C for signed addition.
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Tue, Sep 13, 2022 at 8:37 PM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
> This patch tweaks the match.pd transformation previously added to fold
> (X<<C)+(Y<<C) as (X+Y)<<C that was previously restricted to unsigned
> (wrapping) types, to also allow signed integer types provided that they
> don't trap and the overflow needn't be preserved for sanitization.
> i.e. this should now apply (by default) for "int x,y;", but is disabled
> with -ftrapv.
>
> This unsigned transformation has baked on mainline without problems, so it's
> time to turn up the heat...  LLVM, icc and MSVC perform this optimization.
>
>
> This patch has been tested on x86_64-pc-linux-gnu with make bootstrap and
> make -k check, both with and without --target_board=unix{-m32}, with no
> new failures.  Ok for mainline?

OK.

Thanks,
Richard.

>
>
> 2022-09-13  Roger Sayle  <roger@nextmovesoftware.com>
>
> gcc/ChangeLog
>         * match.pd (op (lshift @0 @1) (lshift @2 @1)): Optimize the
>         expression (X<<C) + (Y<<C) to (X+Y)<<C for signed types, that
>         may have undefined overflow, provided that they don't trap.
>
> gcc/testsuite/ChangeLog
>         * gcc.dg/pr71343-3.c: New test case.
>
>
> Thanks in advance,
> Roger
> --
>